From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] dpaa_eth: Add dpaa_change_carrier()
Date: Fri, 7 Dec 2018 10:15:22 +0100
Message-ID: <20181207091522.GA14223@lunn.ch>
References: <20181206153215.5711-1-joakim.tjernlund@infinera.com>
 <VI1PR04MB5567EBAB7DBF3A5E09388319ECAA0@VI1PR04MB5567.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
        "netdev @ vger . kernel . org" <netdev@vger.kernel.org>
To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:37375 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725978AbeLGJP1 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 7 Dec 2018 04:15:27 -0500
Content-Disposition: inline
In-Reply-To: <VI1PR04MB5567EBAB7DBF3A5E09388319ECAA0@VI1PR04MB5567.eurprd04.prod.outlook.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Dec 07, 2018 at 08:36:48AM +0000, Madalin-cristian Bucur wrote:
> > -----Original Message-----
> > From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> > Sent: Thursday, December 6, 2018 5:32 PM
> > To: netdev @ vger . kernel . org <netdev@vger.kernel.org>; Madalin-
> > cristian Bucur <madalin.bucur@nxp.com>
> > Cc: jocke@infinera.com <joakim.tjernlund@infinera.com>
> > Subject: [PATCH] dpaa_eth: Add dpaa_change_carrier()
> > 
> > This allows to control carrier from /sys/class/net/ethX/carrier
> 
> Hi,
> 
> can you please explain why it's needed?

Hi Madelin

See the patch:

[PATCH] gianfar: Add gfar_change_carrier()

Which is basically the same.

A better approach is being discussed. So for the moment, to stop DaveM
from merging this not knowing it is related to that patch:

NACK

	Andrew