From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilias Apalodimas Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support Date: Fri, 7 Dec 2018 19:20:16 +0200 Message-ID: <20181207172016.GA21965@apalos> References: <1543249591-14563-1-git-send-email-ruxandra.radulescu@nxp.com> <20181205164502.5b11ff7e@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jesper Dangaard Brouer , "netdev@vger.kernel.org" , "davem@davemloft.net" , Ioana Ciornei , "dsahern@gmail.com" , Camelia Alexandra Groza To: Ioana Ciocoi Radulescu Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:33564 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbeLGRUV (ORCPT ); Fri, 7 Dec 2018 12:20:21 -0500 Received: by mail-wm1-f66.google.com with SMTP id r24so1776210wmh.0 for ; Fri, 07 Dec 2018 09:20:20 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi Ioana, > > > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > > > actions are supported for now. Frame header changes are also > > > allowed. I only did a quick grep around the driver so i might be missing something, but i can only see allocations via napi_alloc_frag(). XDP requires pages (either a single page per packet or a driver that does the page management of its own and fits 2 frames in a single page, assuming 4kb pages). Am i missing something on the driver? > > > > Do you have any XDP performance benchmarks on this hardware? > > We have some preliminary perf data that doesn't look great, > but we hope to improve it :) As Jesper said we are doing similar work on a cortex a-53 and plan to work on a-72 as well. We might be able to help out. /Ilias