From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] gianfar: Add gfar_change_carrier()
Date: Fri, 7 Dec 2018 18:26:31 +0100 [thread overview]
Message-ID: <20181207172631.GV14223@lunn.ch> (raw)
In-Reply-To: <d8e83e50ed440ef46a7746ed7abdb9fffc4d7491.camel@infinera.com>
> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs?
I think it makes sense to allow a fixed phy carrier to be changed from
user space. However, i don't think you can easily plumb that to
.ndo_change_carrier(), since that is a MAC feature. You need to change
the fixed_phy_status to indicate the PHY has lost link, and then let
the usual mechanisms tell the MAC it is down and change the carrier
status.
Andrew
next prev parent reply other threads:[~2018-12-07 17:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:31 [PATCH] gianfar: Add gfar_change_carrier() Joakim Tjernlund
2018-12-06 15:47 ` Andrew Lunn
2018-12-06 16:02 ` Joakim Tjernlund
2018-12-06 16:21 ` Andrew Lunn
2018-12-06 16:31 ` Joakim Tjernlund
2018-12-06 16:54 ` Andrew Lunn
2018-12-06 18:46 ` Joakim Tjernlund
2018-12-06 19:43 ` Andrew Lunn
2018-12-07 14:07 ` Joakim Tjernlund
2018-12-07 14:15 ` Andrew Lunn
2018-12-07 17:01 ` Joakim Tjernlund
2018-12-07 17:26 ` Andrew Lunn [this message]
2018-12-07 20:40 ` Florian Fainelli
2018-12-10 15:37 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207172631.GV14223@lunn.ch \
--to=andrew@lunn.ch \
--cc=Joakim.Tjernlund@infinera.com \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).