From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] gianfar: Add gfar_change_carrier()
Date: Fri, 7 Dec 2018 18:26:31 +0100
Message-ID: <20181207172631.GV14223@lunn.ch>
References: <20181206154734.GF18674@lunn.ch>
 <a14732322dfdaa36c4739fc42ef94c3477fe0d72.camel@infinera.com>
 <20181206162131.GG18674@lunn.ch>
 <aea0bca93adf7ce9a6b3324420d1fee09f51a44d.camel@infinera.com>
 <20181206165419.GI18674@lunn.ch>
 <c4ec3da0eae79aaef4c9436f5d7a72b38387c8b2.camel@infinera.com>
 <20181206194317.GK18674@lunn.ch>
 <623d112ab5fc2b8d6edc25b43998960703990716.camel@infinera.com>
 <20181207141527.GP14223@lunn.ch>
 <d8e83e50ed440ef46a7746ed7abdb9fffc4d7491.camel@infinera.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:38047 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726027AbeLGR0h (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 7 Dec 2018 12:26:37 -0500
Content-Disposition: inline
In-Reply-To: <d8e83e50ed440ef46a7746ed7abdb9fffc4d7491.camel@infinera.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs?

I think it makes sense to allow a fixed phy carrier to be changed from
user space. However, i don't think you can easily plumb that to
.ndo_change_carrier(), since that is a MAC feature. You need to change
the fixed_phy_status to indicate the PHY has lost link, and then let
the usual mechanisms tell the MAC it is down and change the carrier
status.

	Andrew