From: Andrew Lunn <andrew@lunn.ch>
To: Tristram.Ha@microchip.com
Cc: marex@denx.de, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com, Woojung.Huh@microchip.com,
UNGLinuxDriver@microchip.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: ksz: Fix port membership
Date: Fri, 7 Dec 2018 21:05:25 +0100 [thread overview]
Message-ID: <20181207200525.GE1294@lunn.ch> (raw)
In-Reply-To: <SN1PR11MB04464EEB30A4CD8854894BBFECAA0@SN1PR11MB0446.namprd11.prod.outlook.com>
> I think if you do this without setting offload_fwd_mark you will
> receive duplicate frame.
I don't think it will, at least not in the normal case. The hardware
should know the egress port, so there is no need to forward a copy to
the CPU. The only time it should forward to the CPU is when the egress
port is not known, so it floods. Without offload_fwd_mark set, the SW
bridge will flood it back out the ports causing duplication. But that
is not too bad. The Marvell driver did this for a while and nothing
bad was reported.
Andrew
next prev parent reply other threads:[~2018-12-07 20:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 17:44 [PATCH] net: dsa: ksz: Fix port membership Marek Vasut
2018-12-07 19:37 ` Tristram.Ha
2018-12-07 19:43 ` Florian Fainelli
2018-12-08 0:01 ` Tristram.Ha
2018-12-07 19:56 ` Marek Vasut
2018-12-08 0:13 ` Tristram.Ha
2018-12-08 4:23 ` Marek Vasut
2018-12-08 11:00 ` Andrew Lunn
2018-12-10 12:43 ` Marek Vasut
2018-12-13 3:51 ` Marek Vasut
2018-12-07 20:05 ` Andrew Lunn [this message]
2018-12-08 0:08 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207200525.GE1294@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).