From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 0/3] Packet based credit mode Date: Fri, 7 Dec 2018 13:29:31 -0700 Message-ID: <20181207202931.GT16806@ziepe.ca> References: <20181130112206.19870-1-leon@kernel.org> <20181207032706.GA20134@ziepe.ca> <20181207060426.GC3845@mtr-leonro.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Doug Ledford , RDMA mailing list , Danit Goldberg , Majd Dibbiny , Saeed Mahameed , linux-netdev To: Leon Romanovsky Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:33042 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbeLGU3e (ORCPT ); Fri, 7 Dec 2018 15:29:34 -0500 Received: by mail-pf1-f193.google.com with SMTP id c123so2471668pfb.0 for ; Fri, 07 Dec 2018 12:29:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181207060426.GC3845@mtr-leonro.mtl.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Dec 07, 2018 at 08:04:26AM +0200, Leon Romanovsky wrote: > On Thu, Dec 06, 2018 at 08:27:06PM -0700, Jason Gunthorpe wrote: > > On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > >From Danit, > > > > > > Packet based credit mode is an alternative end-to-end credit mode for QPs > > > set during their creation. Credits are transported from the responder > > > to the requester to optimize the use of its receive resources. > > > In packet-based credit mode, credits are issued on a per packet basis. > > > > > > The advantage of this feature comes while sending large RDMA messages > > > through switches that are short in memory. > > > > > > The first commit exposes QP creation flag and the HCA capability. The > > > second commit adds support for a new DV QP creation flag. The last > > > commit report packet based credit mode capability via the MLX5DV device > > > capabilities. > > > > > > Thanks > > > > > > Danit Goldberg (3): > > > net/mlx5: Expose packet based credit mode > > > IB/mlx5: Add packet based credit mode support > > > IB/mlx5: Report packet based credit mode device capability > > > > This looks fine to me, can you update the shared branch please > > Done, thanks > 3fd3c80acc17 net/mlx5: Expose packet based credit mode Applied to for-next Thanks, Jason