From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities on
 skbs via page_pool API
Date: Sat, 8 Dec 2018 09:54:32 +0200
Message-ID: <20181208075432.GA1798@apalos>
References: <154413868810.21735.572808840657728172.stgit@firesoul>
 <154413874729.21735.10644578158550468689.stgit@firesoul>
 <20181207.231514.1338299086653086987.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: brouer@redhat.com, netdev@vger.kernel.org, toke@toke.dk,
        ard.biesheuvel@linaro.org, jasowang@redhat.com,
        bjorn.topel@intel.com, w@1wt.eu, saeedm@mellanox.com,
        mykyta.iziumtsev@gmail.com, borkmann@iogearbox.net,
        alexei.starovoitov@gmail.com, tariqt@mellanox.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f65.google.com ([209.85.128.65]:36290 "EHLO
        mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726081AbeLHHyh (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 8 Dec 2018 02:54:37 -0500
Received: by mail-wm1-f65.google.com with SMTP id a18so6565092wmj.1
        for <netdev@vger.kernel.org>; Fri, 07 Dec 2018 23:54:36 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20181207.231514.1338299086653086987.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Dec 07, 2018 at 11:15:14PM -0800, David Miller wrote:
> From: Jesper Dangaard Brouer <brouer@redhat.com>
> Date: Fri, 07 Dec 2018 00:25:47 +0100
> 
> > @@ -744,6 +745,10 @@ struct sk_buff {
> >  				head_frag:1,
> >  				xmit_more:1,
> >  				pfmemalloc:1;
> > +	/* TODO: Future idea, extend mem_info with __u8 flags, and
> > +	 * move bits head_frag and pfmemalloc there.
> > +	 */
> > +	struct xdp_mem_info	mem_info;
> 
> This is 4 bytes right?

With this patchset yes

> 
> I guess I can live with this.

Great news!

> 
> Please do some microbenchmarks to make sure this doesn't show any
> obvious regressions.

Will do

Thanks
/Ilias