From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilias Apalodimas Subject: Re: [net-next PATCH RFC 1/8] page_pool: add helper functions for DMA Date: Sat, 8 Dec 2018 09:55:29 +0200 Message-ID: <20181208075529.GB1798@apalos> References: <154413868810.21735.572808840657728172.stgit@firesoul> <154413873204.21735.4234188123129390865.stgit@firesoul> <20181207.230655.1261252486319967024.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: brouer@redhat.com, netdev@vger.kernel.org, toke@toke.dk, ard.biesheuvel@linaro.org, jasowang@redhat.com, bjorn.topel@intel.com, w@1wt.eu, saeedm@mellanox.com, mykyta.iziumtsev@gmail.com, borkmann@iogearbox.net, alexei.starovoitov@gmail.com, tariqt@mellanox.com To: David Miller Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:38252 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbeLHHze (ORCPT ); Sat, 8 Dec 2018 02:55:34 -0500 Received: by mail-wr1-f68.google.com with SMTP id v13so5796327wrw.5 for ; Fri, 07 Dec 2018 23:55:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181207.230655.1261252486319967024.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Dec 07, 2018 at 11:06:55PM -0800, David Miller wrote: > This isn't going to work on 32-bit platforms where dma_addr_t is a u64, > because the page private is unsigned long. > > Grep for PHY_ADDR_T_64BIT under arch/ to see the vast majority of the > cases where this happens, then ARCH_DMA_ADDR_T_64BIT. Noted, thanks for the heads up. Thanks /Ilias