From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support Date: Sat, 8 Dec 2018 12:16:33 +0100 Message-ID: <20181208111633.GC16502@lunn.ch> References: <20181207181845.21702-1-marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com, Tristram Ha , "David S . Miller" To: Marek Vasut Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:38867 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbeLHLQg (ORCPT ); Sat, 8 Dec 2018 06:16:36 -0500 Content-Disposition: inline In-Reply-To: <20181207181845.21702-1-marex@denx.de> Sender: netdev-owner@vger.kernel.org List-ID: > +static void ksz9477_phy_setup(struct ksz_device *dev, int port, > + struct phy_device *phy) > +{ > + if (port < dev->phy_port_cnt) { > + /* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to > + * disable flow control when rate limiting is used. > + */ > + phy->advertising = phy->supported; > + } > +} > + This has nothing to do with MIB counters. Other than that, is this the same as Tristram's recent submission? Maybe once the comments have been addressed, we can merge that version? Thanks Andrew