From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets Date: Sat, 8 Dec 2018 17:55:05 +0100 Message-ID: <20181208165505.GA25144@lunn.ch> References: <20181207114431.18038-1-bjorn.topel@gmail.com> <20181207212107.365ueu5zale4r46z@ast-mbp.dhcp.thefacebook.com> <20181208161212.560db94d@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , magnus.karlsson@intel.com, magnus.karlsson@gmail.com, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , u9012063@gmail.com, qi.z.zhang@intel.com To: Jesper Dangaard Brouer Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:39109 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbeLHQzM (ORCPT ); Sat, 8 Dec 2018 11:55:12 -0500 Content-Disposition: inline In-Reply-To: <20181208161212.560db94d@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Dec 08, 2018 at 04:12:12PM +0100, Jesper Dangaard Brouer wrote: > On Fri, 7 Dec 2018 13:21:08 -0800 > Alexei Starovoitov wrote: > > > for production I suspect the users would want > > an easy way to stay safe when they're playing with AF_XDP. > > So another builtin program that redirects ssh and ping traffic > > back to the kernel would be a nice addition. > > Are you saying a buildin program that need to parse different kinds of > Eth-type headers (DSA, VLAN, QinqQ) Hi Jesper Parsing DSA headers is quite hard, since most of them are not discoverable, you need to know they are there, and where they actually are. I also don't think there are any use cases for actually trying to parse them on the master interface. You are more likely to want to run the eBPF program on the slave interface, once the DSA header has been removed, and it is clear what interface the frame is actually for. Andrew