From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API Date: Sat, 8 Dec 2018 18:07:29 +0100 Message-ID: <20181208170729.GB25144@lunn.ch> References: <154413874729.21735.10644578158550468689.stgit@firesoul> <20181208095758.GA32028@strlen.de> <72f33f12-9222-cbe7-6ff2-e4b4f86fb17c@gmail.com> <20181208145728.GA10660@apalos> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Dumazet , Florian Westphal , Jesper Dangaard Brouer , netdev@vger.kernel.org, "David S. Miller" , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , ard.biesheuvel@linaro.org, Jason Wang , =?iso-8859-1?Q?Bj=F6rnT=F6pel?= , w@1wt.eu, Saeed Mahameed , mykyta.iziumtsev@gmail.com, Daniel Borkmann , Alexei Starovoitov , Tariq Toukan To: Ilias Apalodimas Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:39152 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbeLHRHd (ORCPT ); Sat, 8 Dec 2018 12:07:33 -0500 Content-Disposition: inline In-Reply-To: <20181208145728.GA10660@apalos> Sender: netdev-owner@vger.kernel.org List-ID: > I got other concerns on the patchset though. Like how much memory is > it 'ok' to keep mapped keeping in mind we are using the streaming > DMA API. Are we going to affect anyone else negatively by doing so ? For mvneta, you can expect the target to have between 512Mbyte to 3G. You can take a look at the DT files to get a better feel for this. All of it should be low enough that it is DMA'able. These SoCs are often used for WiFi access points, and NAS boxes. So i guess the big memory usage on these boxes is the block cache for a NAS device. So if you want to see the impact of the driver using more memory, see if disk performance is affected. Andrew