From mboxrd@z Thu Jan  1 00:00:00 1970
From: Willy Tarreau <w@1wt.eu>
Subject: Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs
 via page_pool API
Date: Sat, 8 Dec 2018 22:06:48 +0100
Message-ID: <20181208210648.GC22126@1wt.eu>
References: <154413874729.21735.10644578158550468689.stgit@firesoul>
 <20181208095758.GA32028@strlen.de>
 <72f33f12-9222-cbe7-6ff2-e4b4f86fb17c@gmail.com>
 <20181208145728.GA10660@apalos>
 <db053651-5de2-26c3-8fae-1a077a665dd0@gmail.com>
 <20181208211153.68f1424e@redhat.com>
 <20181208201447.GA17821@apalos>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>,
        ard.biesheuvel@linaro.org, Jason Wang <jasowang@redhat.com>,
        =?iso-8859-1?Q?Bj=F6rnT=F6pel?= <bjorn.topel@intel.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        mykyta.iziumtsev@gmail.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from wtarreau.pck.nerim.net ([62.212.114.60]:55114 "EHLO 1wt.eu"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726193AbeLHVH1 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 8 Dec 2018 16:07:27 -0500
Content-Disposition: inline
In-Reply-To: <20181208201447.GA17821@apalos>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, Dec 08, 2018 at 10:14:47PM +0200, Ilias Apalodimas wrote:
> On Sat, Dec 08, 2018 at 09:11:53PM +0100, Jesper Dangaard Brouer wrote:
> > >  
> > > I want to make sure you guys thought about splice() stuff, and
> > > skb_try_coalesce(), and GRO, and skb cloning, and ...
> > 
> > Thanks for the pointers. To Ilias, we need to double check skb_try_coalesce()
> > code path, as it does look like we don't handle this correctly.
> > 
> 
> Noted. We did check skb cloning, but not this one indeed

I'll try to run some tests on my clearfog later, but for now I'm still
100% busy until haproxy 1.9 gets released.

Cheers,
Willy