From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next RFC 1/7] devlink: Add devlink_param for port
 register and unregister
Date: Mon, 10 Dec 2018 12:29:34 +0100
Message-ID: <20181210112934.GA2058@nanopsycho>
References: <1543989420-14859-1-git-send-email-vasundhara-v.volam@broadcom.com>
 <1543989420-14859-2-git-send-email-vasundhara-v.volam@broadcom.com>
 <20181205114751.GB2318@nanopsycho>
 <CAACQVJrn5vAbqJnCBVj=zAssy2wZgCE8VaJy8EJ9fj2MKiTMKw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        Jiri Pirko <jiri@mellanox.com>, Netdev <netdev@vger.kernel.org>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f44.google.com ([209.85.128.44]:36888 "EHLO
        mail-wm1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726146AbeLJLgy (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 10 Dec 2018 06:36:54 -0500
Received: by mail-wm1-f44.google.com with SMTP id g67so10812024wmd.2
        for <netdev@vger.kernel.org>; Mon, 10 Dec 2018 03:36:53 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CAACQVJrn5vAbqJnCBVj=zAssy2wZgCE8VaJy8EJ9fj2MKiTMKw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Mon, Dec 10, 2018 at 10:21:03AM CET, vasundhara-v.volam@broadcom.com wrote:
>On Wed, Dec 5, 2018 at 5:24 PM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Wed, Dec 05, 2018 at 06:56:54AM CET, vasundhara-v.volam@broadcom.com wrote:

[...]

>> >+      mutex_lock(&devlink->lock);
>> >+      for (i = 0; i < params_count; i++) {
>> >+              if (!param || !param->name || !param->supported_cmodes) {
>> >+                      err = -EINVAL;
>> >+                      goto rollback;
>> >+              }
>> >+              if (param->generic) {
>> >+                      err = devlink_port_param_generic_verify(param);
>> >+                      if (err)
>> >+                              goto rollback;
>> >+              } else {
>> >+                      err = devlink_port_param_driver_verify(param);
>>
>> This is duplicated code from devlink_params_register(). Once you use a
>> single enum for all params, you can push this into a common function for
>> both devlink_params_register() and devlink_port_params_register()
>Jiri, you are referring to move only param verification code into a
>common function. right?

Once you will have a single enum, you need only one verify() function.