From: Florian Westphal <fw@strlen.de>
To: syzbot <syzbot+592df0494801b6648ec6@syzkaller.appspotmail.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
steffen.klassert@secunet.com, syzkaller-bugs@googlegroups.com
Subject: Re: INFO: rcu detected stall in xfrm_hash_rebuild
Date: Mon, 10 Dec 2018 13:47:24 +0100 [thread overview]
Message-ID: <20181210124724.iuver2va3yjdsokf@breakpoint.cc> (raw)
In-Reply-To: <00000000000075fe86057ca6367e@google.com>
syzbot <syzbot+592df0494801b6648ec6@syzkaller.appspotmail.com> wrote:
> Hello,
>
> syzbot found the following crash on:
[..]
> Workqueue: events xfrm_hash_rebuild
Ignoring this report for a second -- I think it makes sense to see
if we can just remove the entire hash table rebuild/resize code.
After recent tree conversion, we could probably make the exact policies
part of the 'inexact tree' (which would be renamed to 'policy tree' or
some such).
Special-casing the exact policies made a lot of sense when we had
a single list for the inexact policies (to keep its length down).
But now I think we could try to unify all of this and only maintain
the existing tree-based storage.
Would also remove the need to do lookups in two different
data structures (bydst-hash-then-inexact-tree).
What do you think?
next prev parent reply other threads:[~2018-12-10 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 7:50 INFO: rcu detected stall in xfrm_hash_rebuild syzbot
2018-12-10 12:47 ` Florian Westphal [this message]
2018-12-10 17:58 ` David Miller
2018-12-14 13:11 ` Wolfgang Walter
2018-12-14 14:35 ` Florian Westphal
2018-12-14 14:56 ` Herbert Xu
2018-12-14 16:04 ` Christophe Gouault
2018-12-14 16:23 ` Florian Westphal
2018-12-14 16:28 ` Christophe Gouault
2018-12-14 19:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210124724.iuver2va3yjdsokf@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=syzbot+592df0494801b6648ec6@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).