From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>
Cc: bjorn.topel@intel.com, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, bjorn.topel@gmail.com,
qi.z.zhang@intel.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next 2/2] samples/bpf: convert xdpsock to use libbpf for AF_XDP access
Date: Mon, 10 Dec 2018 16:07:50 -0800 [thread overview]
Message-ID: <20181210160750.6c81cac9@cakuba.netronome.com> (raw)
In-Reply-To: <1544456085-14258-3-git-send-email-magnus.karlsson@intel.com>
On Mon, 10 Dec 2018 16:34:45 +0100, Magnus Karlsson wrote:
> diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
> index 57ecadc..ca94cfb 100644
> --- a/samples/bpf/xdpsock_user.c
> +++ b/samples/bpf/xdpsock_user.c
> @@ -44,15 +44,8 @@
> #define PF_XDP AF_XDP
> #endif
>
> -#define NUM_FRAMES 131072
> -#define FRAME_HEADROOM 0
> -#define FRAME_SHIFT 11
> -#define FRAME_SIZE 2048
> -#define NUM_DESCS 1024
> -#define BATCH_SIZE 16
> -
> -#define FQ_NUM_DESCS 1024
> -#define CQ_NUM_DESCS 1024
> +#define NUM_FRAMES (4 * 1024)
> +#define BATCH_SIZE 64
nit: small changes to the defines are not mentioned in the commit msg
next prev parent reply other threads:[~2018-12-11 0:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 15:34 [PATCH bpf-next 0/2] libbpf: adding af_xdp support Magnus Karlsson
2018-12-10 15:34 ` [PATCH bpf-next 1/2] libbpf: add support for using AF_XDP sockets Magnus Karlsson
2018-12-12 0:48 ` Daniel Borkmann
2018-12-12 0:57 ` Daniel Borkmann
2018-12-12 1:14 ` Daniel Borkmann
2018-12-12 7:59 ` Magnus Karlsson
2018-12-12 8:08 ` Magnus Karlsson
2018-12-10 15:34 ` [PATCH bpf-next 2/2] samples/bpf: convert xdpsock to use libbpf for AF_XDP access Magnus Karlsson
2018-12-11 0:07 ` Jakub Kicinski [this message]
2018-12-12 7:57 ` Magnus Karlsson
2018-12-17 11:07 ` Jesper Dangaard Brouer
2018-12-17 12:47 ` Magnus Karlsson
2018-12-11 0:10 ` [PATCH bpf-next 0/2] libbpf: adding af_xdp support Jakub Kicinski
2018-12-12 0:45 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210160750.6c81cac9@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).