From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>
Cc: bjorn.topel@intel.com, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, bjorn.topel@gmail.com,
qi.z.zhang@intel.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next 0/2] libbpf: adding af_xdp support
Date: Mon, 10 Dec 2018 16:10:49 -0800 [thread overview]
Message-ID: <20181210161049.7b66cc86@cakuba.netronome.com> (raw)
In-Reply-To: <1544456085-14258-1-git-send-email-magnus.karlsson@intel.com>
On Mon, 10 Dec 2018 16:34:43 +0100, Magnus Karlsson wrote:
> * Is it ok to have static inline functions in this library? They are
> currently static inline for performance reasons, but maybe -flto
> could fix this but not everyone uses this.
I'd think so, we have few static inlines in kernel uapi headers.
> * I have included 3 more header files compared to libbpf without AF_XDP
> functionality: barrier.h (for the memory barriers used for correctly
> ordered accesses to the rings) compiler.h (for one unliekly and one
> likely with a tiny performance impact, if any) and list.h (some
> extra functions). What to do with these (and the header files they
> include) as they need to be dual licensed for libbpf.so?
Indeed, but I think we already have that problem, we include barrier.h
indirectly for the perf ring helper which in turn includes compiler.h
and list.h is included directly.
Thanks for the work!
next prev parent reply other threads:[~2018-12-11 0:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 15:34 [PATCH bpf-next 0/2] libbpf: adding af_xdp support Magnus Karlsson
2018-12-10 15:34 ` [PATCH bpf-next 1/2] libbpf: add support for using AF_XDP sockets Magnus Karlsson
2018-12-12 0:48 ` Daniel Borkmann
2018-12-12 0:57 ` Daniel Borkmann
2018-12-12 1:14 ` Daniel Borkmann
2018-12-12 7:59 ` Magnus Karlsson
2018-12-12 8:08 ` Magnus Karlsson
2018-12-10 15:34 ` [PATCH bpf-next 2/2] samples/bpf: convert xdpsock to use libbpf for AF_XDP access Magnus Karlsson
2018-12-11 0:07 ` Jakub Kicinski
2018-12-12 7:57 ` Magnus Karlsson
2018-12-17 11:07 ` Jesper Dangaard Brouer
2018-12-17 12:47 ` Magnus Karlsson
2018-12-11 0:10 ` Jakub Kicinski [this message]
2018-12-12 0:45 ` [PATCH bpf-next 0/2] libbpf: adding af_xdp support Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210161049.7b66cc86@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).