From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net 2/4] vhost_net: rework on the lock ordering for busy polling Date: Mon, 10 Dec 2018 23:04:08 -0500 Message-ID: <20181210230106-mutt-send-email-mst@kernel.org> References: <20181210094454.21144-1-jasowang@redhat.com> <20181210094454.21144-3-jasowang@redhat.com> <20181210203119-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Jason Wang Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org T24gVHVlLCBEZWMgMTEsIDIwMTggYXQgMTE6MDY6NDNBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzEyLzExIOS4iuWNiDk6MzQsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIE1vbiwgRGVjIDEwLCAyMDE4IGF0IDA1OjQ0OjUyUE0gKzA4MDAsIEphc29uIFdh bmcgd3JvdGU6Cj4gPiA+IFdoZW4gd2UgdHJ5IHRvIGRvIHJ4IGJ1c3kgcG9sbGluZyBpbiB0eCBw YXRoIGluIGNvbW1pdCA0NDFhYmRlNGNkODQKPiA+ID4gKCJuZXQ6IHZob3N0OiBhZGQgcnggYnVz eSBwb2xsaW5nIGluIHR4IHBhdGgiKSwgd2UgbG9jayByeCB2cSBtdXRleAo+ID4gPiBhZnRlciB0 eCB2cSBtdXRleCBpcyBoZWxkLiBUaGlzIG1heSBsZWFkIGRlYWRsb2NrIHNvIHdlIHRyeSB0byBs b2NrIHZxCj4gPiA+IG9uZSBieSBvbmUgaW4gY29tbWl0IDc4MTM5Yzk0ZGM4YyAoIm5ldDogdmhv c3Q6IGxvY2sgdGhlIHZxcyBvbmUgYnkKPiA+ID4gb25lIikuIFdpdGggdGhpcyBjb21taXQsIHdl IGF2b2lkIHRoZSBkZWFkbG9jayB3aXRoIHRoZSBhc3N1bXB0aW9uCj4gPiA+IHRoYXQgaGFuZGxl X3J4KCkgYW5kIGhhbmRsZV90eCgpIHJ1biBpbiBhIHNhbWUgcHJvY2Vzcy4gQnV0IHRoaXMKPiA+ ID4gY29tbWl0IHJlbW92ZSB0aGUgcHJvdGVjdGlvbiBmb3IgSU9UTEIgdXBkYXRpbmcgd2hpY2gg cmVxdWlyZXMgdGhlCj4gPiA+IG11dGV4IG9mIGVhY2ggdnEgdG8gYmUgaGVsZC4KPiA+ID4gCj4g PiA+IFRvIHNvbHZlIHRoaXMgaXNzdWUsIHRoZSBmaXJzdCBzdGVwIGlzIHRvIGhhdmUgYSBleGFj dCBzYW1lIGxvY2sKPiA+ID4gb3JkZXJpbmcgZm9yIHZob3N0X25ldC4gVGhpcyBpcyBkb25lIHRo cm91Z2g6Cj4gPiA+IAo+ID4gPiAtIEZvciBoYW5kbGVfcngoKSwgaWYgYnVzeSBwb2xsaW5nIGlz IGVuYWJsZWQsIGxvY2sgdHggdnEgaW1tZWRpYXRlbHkuCj4gPiA+IC0gRm9yIGhhbmRsZV90eCgp LCBhbHdheXMgbG9jayByeCB2cSBiZWZvcmUgdHggdnEsIGFuZCB1bmxvY2sgaXQgaWYKPiA+ID4g ICAgYnVzeSBwb2xsaW5nIGlzIG5vdCBlbmFibGVkLgo+ID4gPiAtIFJlbW92ZSB0aGUgdHJpY2t5 IGxvY2tpbmcgY29kZXMgaW4gYnVzeSBwb2xsaW5nLgo+ID4gPiAKPiA+ID4gV2l0aCB0aGlzLCB3 ZSBjYW4gaGF2ZSBhIGV4YWN0IHNhbWUgbG9jayBvcmRlcmluZyBmb3Igdmhvc3RfbmV0LCB0aGlz Cj4gPiA+IGFsbG93cyB1cyB0byBzYWZlbHkgcmV2ZXJ0IGNvbW1pdCA3ODEzOWM5NGRjOGMgKCJu ZXQ6IHZob3N0OiBsb2NrIHRoZQo+ID4gPiB2cXMgb25lIGJ5IG9uZSIpIGluIG5leHQgcGF0Y2gu Cj4gPiA+IAo+ID4gPiBUaGUgcGF0Y2ggd2lsbCBhZGQgdHdvIG1vcmUgYXRvbWljIG9wZXJhdGlv bnMgb24gdGhlIHR4IHBhdGggZHVyaW5nCj4gPiA+IGVhY2ggcm91bmQgb2YgaGFuZGxlX3R4KCku IDEgYnl0ZSBUQ1BfUlIgZG9lcyBub3Qgbm90aWNlIHN1Y2gKPiA+ID4gb3ZlcmhlYWQuCj4gPiA+ IAo+ID4gPiBGaXhlczogY29tbWl0IDc4MTM5Yzk0ZGM4YyAoIm5ldDogdmhvc3Q6IGxvY2sgdGhl IHZxcyBvbmUgYnkgb25lIikKPiA+ID4gQ2M6IFRvbmdoYW8gWmhhbmc8eGlhbmd4aWEubS55dWVA Z21haWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBXYW5nPGphc293YW5nQHJlZGhh dC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgIGRyaXZlcnMvdmhvc3QvbmV0LmMgfCAxOCArKysrKysr KysrKysrKystLS0KPiA+ID4gICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Zob3N0L25ldC5j IGIvZHJpdmVycy92aG9zdC9uZXQuYwo+ID4gPiBpbmRleCBhYjExYjJiZWUyNzMuLjVmMjcyYWI0 ZDViNCAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy92aG9zdC9uZXQuYwo+ID4gPiArKysgYi9k cml2ZXJzL3Zob3N0L25ldC5jCj4gPiA+IEBAIC01MTMsNyArNTEzLDYgQEAgc3RhdGljIHZvaWQg dmhvc3RfbmV0X2J1c3lfcG9sbChzdHJ1Y3Qgdmhvc3RfbmV0ICpuZXQsCj4gPiA+ICAgCXN0cnVj dCBzb2NrZXQgKnNvY2s7Cj4gPiA+ICAgCXN0cnVjdCB2aG9zdF92aXJ0cXVldWUgKnZxID0gcG9s bF9yeCA/IHR2cSA6IHJ2cTsKPiA+ID4gLQltdXRleF9sb2NrX25lc3RlZCgmdnEtPm11dGV4LCBw b2xsX3J4ID8gVkhPU1RfTkVUX1ZRX1RYOiBWSE9TVF9ORVRfVlFfUlgpOwo+ID4gPiAgIAl2aG9z dF9kaXNhYmxlX25vdGlmeSgmbmV0LT5kZXYsIHZxKTsKPiA+ID4gICAJc29jayA9IHJ2cS0+cHJp dmF0ZV9kYXRhOwo+ID4gPiBAQCAtNTQzLDggKzU0Miw2IEBAIHN0YXRpYyB2b2lkIHZob3N0X25l dF9idXN5X3BvbGwoc3RydWN0IHZob3N0X25ldCAqbmV0LAo+ID4gPiAgIAkJdmhvc3RfbmV0X2J1 c3lfcG9sbF90cnlfcXVldWUobmV0LCB2cSk7Cj4gPiA+ICAgCWVsc2UgaWYgKCFwb2xsX3J4KSAv KiBPbiB0eCBoZXJlLCBzb2NrIGhhcyBubyByeCBkYXRhLiAqLwo+ID4gPiAgIAkJdmhvc3RfZW5h YmxlX25vdGlmeSgmbmV0LT5kZXYsIHJ2cSk7Cj4gPiA+IC0KPiA+ID4gLQltdXRleF91bmxvY2so JnZxLT5tdXRleCk7Cj4gPiA+ICAgfQo+ID4gPiAgIHN0YXRpYyBpbnQgdmhvc3RfbmV0X3R4X2dl dF92cV9kZXNjKHN0cnVjdCB2aG9zdF9uZXQgKm5ldCwKPiA+ID4gQEAgLTkxMywxMCArOTEwLDE2 IEBAIHN0YXRpYyB2b2lkIGhhbmRsZV90eF96ZXJvY29weShzdHJ1Y3Qgdmhvc3RfbmV0ICpuZXQs IHN0cnVjdCBzb2NrZXQgKnNvY2spCj4gPiA+ICAgc3RhdGljIHZvaWQgaGFuZGxlX3R4KHN0cnVj dCB2aG9zdF9uZXQgKm5ldCkKPiA+ID4gICB7Cj4gPiA+ICAgCXN0cnVjdCB2aG9zdF9uZXRfdmly dHF1ZXVlICpudnEgPSAmbmV0LT52cXNbVkhPU1RfTkVUX1ZRX1RYXTsKPiA+ID4gKwlzdHJ1Y3Qg dmhvc3RfbmV0X3ZpcnRxdWV1ZSAqbnZxX3J4ID0gJm5ldC0+dnFzW1ZIT1NUX05FVF9WUV9SWF07 Cj4gPiA+ICAgCXN0cnVjdCB2aG9zdF92aXJ0cXVldWUgKnZxID0gJm52cS0+dnE7Cj4gPiA+ICsJ c3RydWN0IHZob3N0X3ZpcnRxdWV1ZSAqdnFfcnggPSAmbnZxX3J4LT52cTsKPiA+ID4gICAJc3Ry dWN0IHNvY2tldCAqc29jazsKPiA+ID4gKwltdXRleF9sb2NrX25lc3RlZCgmdnFfcngtPm11dGV4 LCBWSE9TVF9ORVRfVlFfUlgpOwo+ID4gPiAgIAltdXRleF9sb2NrX25lc3RlZCgmdnEtPm11dGV4 LCBWSE9TVF9ORVRfVlFfVFgpOwo+ID4gPiArCWlmICghdnEtPmJ1c3lsb29wX3RpbWVvdXQpCj4g PiA+ICsJCW11dGV4X3VubG9jaygmdnFfcngtPm11dGV4KTsKPiA+ID4gKwo+ID4gPiAgIAlzb2Nr ID0gdnEtPnByaXZhdGVfZGF0YTsKPiA+ID4gICAJaWYgKCFzb2NrKQo+ID4gPiAgIAkJZ290byBv dXQ7Cj4gPiA+IEBAIC05MzMsNiArOTM2LDggQEAgc3RhdGljIHZvaWQgaGFuZGxlX3R4KHN0cnVj dCB2aG9zdF9uZXQgKm5ldCkKPiA+ID4gICAJCWhhbmRsZV90eF9jb3B5KG5ldCwgc29jayk7Cj4g PiA+ICAgb3V0Ogo+ID4gPiArCWlmICh2cS0+YnVzeWxvb3BfdGltZW91dCkKPiA+ID4gKwkJbXV0 ZXhfdW5sb2NrKCZ2cV9yeC0+bXV0ZXgpOwo+ID4gPiAgIAltdXRleF91bmxvY2soJnZxLT5tdXRl eCk7Cj4gPiA+ICAgfQo+ID4gU28gcnggbXV0ZXggdGFrZW4gb24gdHggcGF0aCBub3cuICBBbmQg dHggbXV0ZXggaXMgb24gcmMgcGF0aCAuLi4gIFRoaXMKPiA+IGlzIGp1c3QgbWVzc2VkIHVwLiBX aHkgY2FuJ3QgdHggcG9sbGluZyBkcm9wIHJ4IGxvY2sgYmVmb3JlCj4gPiBnZXR0aW5nIHRoZSB0 eCBsb2NrIGFuZCB2aWNlIHZlcnNhPwo+IAo+IAo+IEJlY2F1c2Ugd2Ugd2FudCB0byBwb2xsIGJv dGggdHggYW5kIHJ4IHZpcnRxdWV1ZSBhdCB0aGUgc2FtZSB0aW1lCj4gKHZob3N0X25ldF9idXN5 X3BvbGwoKSkuCj4gCj4gwqDCoMKgIHdoaWxlICh2aG9zdF9jYW5fYnVzeV9wb2xsKGVuZHRpbWUp KSB7Cj4gwqDCoCDCoMKgwqAgwqBpZiAodmhvc3RfaGFzX3dvcmsoJm5ldC0+ZGV2KSkgewo+IMKg wqAgwqDCoMKgIMKgwqDCoCDCoCpidXN5bG9vcF9pbnRyID0gdHJ1ZTsKPiDCoMKgIMKgwqDCoCDC oMKgwqAgwqBicmVhazsKPiDCoMKgIMKgwqDCoCDCoH0KPiAKPiDCoMKgIMKgwqDCoCDCoGlmICgo c29ja19oYXNfcnhfZGF0YShzb2NrKSAmJgo+IMKgwqAgwqDCoMKgIMKgwqDCoMKgwqAgIXZob3N0 X3ZxX2F2YWlsX2VtcHR5KCZuZXQtPmRldiwgcnZxKSkgfHwKPiDCoMKgIMKgwqDCoCDCoMKgwqDC oCAhdmhvc3RfdnFfYXZhaWxfZW1wdHkoJm5ldC0+ZGV2LCB0dnEpKQo+IMKgwqAgwqDCoMKgIMKg wqDCoCDCoGJyZWFrOwo+IAo+IMKgwqAgwqDCoMKgIMKgY3B1X3JlbGF4KCk7Cj4gCj4gwqDCoCDC oH0KPiAKPiAKPiBBbmQgd2UgZGlzYWJsZSBraWNrcyBhbmQgbm90aWZpY2F0aW9uIGZvciBiZXR0 ZXIgcGVyZm9ybWFuY2UuCgpSaWdodCBidXQgaXQncyBhbGwgc2xvdyBwYXRoIC0gaXQgaGFwcGVu cyB3aGVuIHF1ZXVlIGlzCm90aGVyd2lzZSBlbXB0eS4gU28gdGhpcyBpcyB3aGF0IEkgYW0gc2F5 aW5nOiBsZXQncyBkcm9wIHRoZSBsb2Nrcwp3ZSBob2xkIGFyb3VuZCB0aGlzLgoKCj4gCj4gPiAK PiA+IE9yIGlmIHdlIHJlYWxseSB3YW50ZWQgdG8gZm9yY2UgZXZlcnl0aGluZyB0byBiZSBsb2Nr ZWQgYXQKPiA+IGFsbCB0aW1lcywgbGV0J3MganVzdCB1c2UgYSBzaW5nbGUgbXV0ZXguCj4gPiAK PiA+IAo+ID4gCj4gCj4gV2UgY291bGQsIGJ1dCBpdCBtaWdodCByZXF1aXJlcyBtb3JlIGNoYW5n ZXMgd2hpY2ggY291bGQgYmUgZG9uZSBmb3IgLW5leHQgSQo+IGJlbGlldmUuCj4gCj4gCj4gVGhh bmtzCgpJJ2QgcmF0aGVyIHdlIGtlcHQgdGhlIGZpbmUgZ3JhaW5lZCBsb2NraW5nLiBFLmcuIHBl b3BsZSBhcmUKbG9va2luZyBhdCBzcGxpdHRpbmcgdGhlIHR4IGFuZCByeCB0aHJlYWRzLiBCdXQg aWYgbm90IHBvc3NpYmxlCmxldCdzIGZpeCBpdCBjbGVhbmx5IHdpdGggYSBjb2Fyc2UtZ3JhaW5l ZCBvbmUuIEEgbWVzcyBoZXJlIHdpbGwKanVzdCBjcmVhdGUgbW9yZSB0cm91YmxlIGxhdGVyLgoK LS0gCk1TVApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpW aXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91 bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlz dGluZm8vdmlydHVhbGl6YXRpb24=