From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 3/5] net: dsa: ksz: Factor out common tag code Date: Tue, 11 Dec 2018 08:40:00 +0100 Message-ID: <20181211074000.GA31168@lunn.ch> References: <20181207181845.21702-1-marex@denx.de> <20181207181845.21702-3-marex@denx.de> <20181208113448.GD16502@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com, davem@davemloft.net, marex@denx.de To: Tristram.Ha@microchip.com Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:42425 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbeLKHkE (ORCPT ); Tue, 11 Dec 2018 02:40:04 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > So this ksz_tag_ops is still not acceptable? As I understand the kernel is > using this mechanism all over the places. Hi Tristram It is used all other the place, but generally, not in the hot path, just the control plain. > What is left is a direct copying of the transmit and receive functions for each > new switch tail tag format. As i said, one of these looks easy to achieve, the other i did not look at too closely, but needs more work. Andrew