From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kai-Heng Feng Subject: [PATCH 2/2] igb: Exclude device from suspend direct complete optimization Date: Tue, 11 Dec 2018 15:59:38 +0800 Message-ID: <20181211075938.32026-2-kai.heng.feng@canonical.com> References: <20181211075938.32026-1-kai.heng.feng@canonical.com> Cc: davem@davemloft.net, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kai-Heng Feng To: jeffrey.t.kirsher@intel.com Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:59760 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbeLKH7u (ORCPT ); Tue, 11 Dec 2018 02:59:50 -0500 In-Reply-To: <20181211075938.32026-1-kai.heng.feng@canonical.com> Sender: netdev-owner@vger.kernel.org List-ID: igb sets different WoL settings in system suspend callback and runtime suspend callback. The suspend direct complete optimization leaves igb in runtime suspneded state with wrong WoL setting during system suspend. To fix this, we need to disable suspend direct complete optimization to let igb always use suspend callback to set correct WoL during system suspend. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 2ce3f2cb156d..e0e8f7a708e9 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -3467,6 +3467,9 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) break; } } + + dev_pm_set_driver_flags(&pdev->dev, DPM_FLAG_NEVER_SKIP); + pm_runtime_put_noidle(&pdev->dev); return 0; -- 2.17.1