From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next v2 RFC 7/8] devlink: Add a generic port parameter Date: Tue, 11 Dec 2018 10:18:39 -0800 Message-ID: <20181211101839.01d817ac@cakuba.netronome.com> References: <1544518008-15289-1-git-send-email-vasundhara-v.volam@broadcom.com> <1544518008-15289-8-git-send-email-vasundhara-v.volam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com, netdev@vger.kernel.org To: Vasundhara Volam Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:33847 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbeLKSSo (ORCPT ); Tue, 11 Dec 2018 13:18:44 -0500 Received: by mail-pg1-f194.google.com with SMTP id 17so7016797pgg.1 for ; Tue, 11 Dec 2018 10:18:43 -0800 (PST) In-Reply-To: <1544518008-15289-8-git-send-email-vasundhara-v.volam@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 11 Dec 2018 14:16:47 +0530, Vasundhara Volam wrote: > wake-on-lan - Enables Wake on Lan for this port. If enabled, > the controller asserts a wake pin based on the wake-on-lan type. > > Cc: Jiri Pirko > Signed-off-by: Vasundhara Volam As explained previously I think it's a very bad idea to add existing configuration options to devlink, just because devlink has the ability to persist the setting in NVM. Especially that for WoL you have to get the link up so you potentially have all link config stuff as well. And that n-tuple filters are one of the WoL options, meaning we'd need the ability to persist n-tuple filters via devlink. Your effort would be far better spent helping with migrating ethtool to netlink, and allowing persisting there. I have not heard any reason why devlink is a better fit. I can imagine you're just doing it here because it's less effort for you since ethtool is not yet migrated. So I'm opposed, let's call it a nack.