From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [Patch net-next] net_sched: fold tcf_block_cb_call() into tc_setup_cb_call() Date: Tue, 11 Dec 2018 13:44:04 -0800 Message-ID: <20181211134404.0adf3856@cakuba.netronome.com> References: <20181211191546.15255-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Oz Shlomo , Jiri Pirko To: Cong Wang Return-path: Received: from mail-pf1-f176.google.com ([209.85.210.176]:45215 "EHLO mail-pf1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbeLKVoI (ORCPT ); Tue, 11 Dec 2018 16:44:08 -0500 Received: by mail-pf1-f176.google.com with SMTP id g62so7755087pfd.12 for ; Tue, 11 Dec 2018 13:44:08 -0800 (PST) In-Reply-To: <20181211191546.15255-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 11 Dec 2018 11:15:46 -0800, Cong Wang wrote: > After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"), > tc_setup_cb_call() is nearly identical to tcf_block_cb_call(), > so we can just fold tcf_block_cb_call() into tc_setup_cb_call() > and remove its unused parameter 'exts'. > > Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism") > Cc: Oz Shlomo > Cc: Jiri Pirko > Signed-off-by: Cong Wang Thanks, I didn't want to nit pick too much on Oz's patch :) The Fixes tag is superfluous, this is far from a bug, unnecessary noise for backporters.