From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [Patch net-next] net_sched: fold tcf_block_cb_call() into
 tc_setup_cb_call()
Date: Tue, 11 Dec 2018 16:25:49 -0800
Message-ID: <20181211162549.7e0a879c@cakuba.netronome.com>
References: <20181211191546.15255-1-xiyou.wangcong@gmail.com>
        <20181211134404.0adf3856@cakuba.netronome.com>
        <CAM_iQpV3zR8aVNPnejFWRXUqibhaX+mTo88P3JCBLv2XpTWMew@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Oz Shlomo <ozsh@mellanox.com>, Jiri Pirko <jiri@mellanox.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f171.google.com ([209.85.214.171]:41616 "EHLO
        mail-pl1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726201AbeLLAZz (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 11 Dec 2018 19:25:55 -0500
Received: by mail-pl1-f171.google.com with SMTP id u6so7700826plm.8
        for <netdev@vger.kernel.org>; Tue, 11 Dec 2018 16:25:55 -0800 (PST)
In-Reply-To: <CAM_iQpV3zR8aVNPnejFWRXUqibhaX+mTo88P3JCBLv2XpTWMew@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 11 Dec 2018 16:05:08 -0800, Cong Wang wrote:
> On Tue, Dec 11, 2018 at 1:44 PM Jakub Kicinski wrote:
> > On Tue, 11 Dec 2018 11:15:46 -0800, Cong Wang wrote:  
> > > After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"),
> > > tc_setup_cb_call() is nearly identical to tcf_block_cb_call(),
> > > so we can just fold tcf_block_cb_call() into tc_setup_cb_call()
> > > and remove its unused parameter 'exts'.
> > >
> > > Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism")
> > > Cc: Oz Shlomo <ozsh@mellanox.com>
> > > Cc: Jiri Pirko <jiri@mellanox.com>
> > > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>  
> >
> > Thanks, I didn't want to nit pick too much on Oz's patch :)
> >
> > The Fixes tag is superfluous, this is far from a bug, unnecessary noise
> > for backporters.  
> 
> Odd, you just Acked a patch which uses Fixes tag for a newline
> change:
> 
> commit 10a5ce98539948affbdc28dc0f39a1b6b2307f9d
> Author: Martin KaFai Lau <kafai@fb.com>
> Date:   Mon Dec 10 10:53:24 2018 -0800
> 
>     bpf: bpftool: Fix newline and p_err issue
> 
>     This patch fixes a few newline issues and also
>     replaces p_err with p_info in prog.c
> 
>     Fixes: b053b439b72a ("bpf: libbpf: bpftool: Print bpf_line_info
> during prog dump")
>     Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
>     Signed-off-by: Martin KaFai Lau <kafai@fb.com>
>     Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>     Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> 
> Jakub, please guide me which Jakub I should trust. :)
> 
> Or you believe a newline change is more close to a bug fix
> than this?
> 
> Please help!

p_err() breaks JSON so it's an actual bug.