From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Subject: Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports Date: Wed, 12 Dec 2018 10:32:13 +0100 Message-ID: <20181212093213.GB3219@kwain> References: <20181211163228.26130-1-antoine.tenart@bootlin.com> <20181211163635.GG30658@n2100.armlinux.org.uk> <7b61c1fbf51a409684568216e799ebe3@IL-EXCH01.marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Russell King - ARM Linux , Antoine Tenart , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , "maxime.chevallier@bootlin.com" , "gregory.clement@bootlin.com" , "miquel.raynal@bootlin.com" , Nadav Haklai , Yan Markman , "mw@semihalf.com" , Baruch Siach To: Stefan Chulski Return-path: Content-Disposition: inline In-Reply-To: <7b61c1fbf51a409684568216e799ebe3@IL-EXCH01.marvell.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Stefan, On Tue, Dec 11, 2018 at 09:11:31PM +0000, Stefan Chulski wrote: > > > > > Are these modes supported on anything except port 0? If not, you should be > > rejecting these, rather than just treating them as RGMII. > > In CP115(which has PPv2) PHY_INTERFACE_MODE_10GKR supported on ports 0 and 1 > PHY_INTERFACE_MODE_XAUI/PHY_INTERFACE_MODE_RXAUI supported only on port 0. That's right. But I think we need to first fix this, and then when adding support for the cp115 we'll rework this. We will need a way to differentiate the CP110 PPv2 from the CP115 PPv2. Thanks! Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com