From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix
Date: Wed, 12 Dec 2018 10:41:01 -0800
Message-ID: <20181212103804.467945cc@cakuba.netronome.com>
References: <20181211115607.13774-1-alice.ferrazzi@gmail.com>
 <20181211115607.13774-5-alice.ferrazzi@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: Alice Ferrazzi <alice.ferrazzi@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20181211115607.13774-5-alice.ferrazzi@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Tue, 11 Dec 2018 20:56:04 +0900, Alice Ferrazzi wrote:
> Signed-off-by: Alice Ferrazzi <alice.ferrazzi@gmail.com>

Thanks, are you just running pylint to catch those?  I tried in the
past but it's very noisy and it lacked "understanding" of some python3
modules.  Would you mind giving us a quick 101 of how to catch such
errors? :)

> -def bpf_obj(name, sec=".text", path=bpf_test_dir,):
> +
> +def bpf_obj(name, sec=".text", path=bpf_test_dir, ):
>      return "obj %s sec %s" % (os.path.join(path, name), sec)
>  

I think this one is just a typo.  bpf_obj() seems to always get called
with one param, no?