From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alice Ferrazzi <alice.ferrazzi@gmail.com>,
ast@kernel.org, shuah@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] selftest/bpf: fix E501 line too long
Date: Wed, 12 Dec 2018 11:06:12 -0800 [thread overview]
Message-ID: <20181212110612.58c013fe@cakuba.netronome.com> (raw)
In-Reply-To: <62f6127d-edf6-2d41-cd7d-1c1c20607b38@iogearbox.net>
On Wed, 12 Dec 2018 11:24:02 +0100, Daniel Borkmann wrote:
> > - raise Exception("Time out waiting for program counts to stabilize want %d/%d, have %d bound, %d loaded" % (
> > + raise Exception("Time out waiting for program counts to \
> > +stabilize want %d/%d, have %d bound, %d loaded" % (
> > bound, total, nbound, nprogs))
>
> I'll leave the test_offload.py ones up to Jakub, but to me it seems
> this particular change here would actually make the code look worse
> and harder to grep for error messages, so my preference would be to
> at least leave the error messages as-is. Also seems it's not a 'must'
> in pep8 [0].
>
> [0] https://www.python.org/dev/peps/pep-0008/#maximum-line-length
Thanks, agreed, this has been run through checkpatch, so the line
lengths should be fine (and we don't want error messages split).
next prev parent reply other threads:[~2018-12-12 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 11:56 [PATCH 0/7] selftest/bpf fix PEP8 warnings Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 1/7] selftest/bpf: Fix trailing semicolon in the statement Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 2/7] selftest/bpf: optimize import Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 3/7] selftest/bpf: PEP 8: multiple statements on one line (colon) Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix Alice Ferrazzi
2018-12-12 18:41 ` Jakub Kicinski
2018-12-11 11:56 ` [PATCH 5/7] selftest/bpf: Fix PEP8 ambiguous variable name Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 6/7] selftest/bpf: remove redundant parenthesis Alice Ferrazzi
2018-12-12 19:04 ` Jakub Kicinski
2018-12-12 21:15 ` Edward Cree
2018-12-13 0:25 ` Jakub Kicinski
2018-12-11 11:56 ` [PATCH 7/7] selftest/bpf: fix E501 line too long Alice Ferrazzi
2018-12-12 10:24 ` Daniel Borkmann
2018-12-12 19:06 ` Jakub Kicinski [this message]
2018-12-25 0:35 ` [LKP] [selftest/bpf] b870be2f1b: kernel_selftests.bpf.test_offload.py.fail kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212110612.58c013fe@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alice.ferrazzi@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).