From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH 7/7] selftest/bpf: fix E501 line too long Date: Wed, 12 Dec 2018 11:06:12 -0800 Message-ID: <20181212110612.58c013fe@cakuba.netronome.com> References: <20181211115607.13774-1-alice.ferrazzi@gmail.com> <20181211115607.13774-8-alice.ferrazzi@gmail.com> <62f6127d-edf6-2d41-cd7d-1c1c20607b38@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alice Ferrazzi , ast@kernel.org, shuah@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Daniel Borkmann Return-path: In-Reply-To: <62f6127d-edf6-2d41-cd7d-1c1c20607b38@iogearbox.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 12 Dec 2018 11:24:02 +0100, Daniel Borkmann wrote: > > - raise Exception("Time out waiting for program counts to stabilize want %d/%d, have %d bound, %d loaded" % ( > > + raise Exception("Time out waiting for program counts to \ > > +stabilize want %d/%d, have %d bound, %d loaded" % ( > > bound, total, nbound, nprogs)) > > I'll leave the test_offload.py ones up to Jakub, but to me it seems > this particular change here would actually make the code look worse > and harder to grep for error messages, so my preference would be to > at least leave the error messages as-is. Also seems it's not a 'must' > in pep8 [0]. > > [0] https://www.python.org/dev/peps/pep-0008/#maximum-line-length Thanks, agreed, this has been run through checkpatch, so the line lengths should be fine (and we don't want error messages split).