From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: "netdev @ vger . kernel . org" <netdev@vger.kernel.org>,
"claudiu . manoil @ nxp . com" <claudiu.manoil@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCHv2] gianfar: Add gfar_change_carrier() for Fixed PHYs
Date: Wed, 12 Dec 2018 13:42:32 +0100 [thread overview]
Message-ID: <20181212124232.GB1549@lunn.ch> (raw)
In-Reply-To: <20181212123308.20100-1-joakim.tjernlund@infinera.com>
On Wed, Dec 12, 2018 at 01:33:08PM +0100, Joakim Tjernlund wrote:
> This allows to control carrier from /sys/class/net/ethX/carrier for
> Fixed PHYs.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> ---
> v2 - Only allow carrier changes for Fixed PHYs
>
> Florian: I have reimpl. this as I think you meant by registering
> a Fixed PHY callback.
> Andrew: Are happy with this as well?
Hi Joakim
The basic idea is O.K.
>
> If this is OK I will sent the other 2 drivers.
Rather than replicating the code three times, how about putting all
the code in the fixed phy driver, exporting a fixed_phy_change_carrier
function which can be assigned to the .ndo.
Andrew
next prev parent reply other threads:[~2018-12-12 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 12:33 [PATCHv2] gianfar: Add gfar_change_carrier() for Fixed PHYs Joakim Tjernlund
2018-12-12 12:42 ` Andrew Lunn [this message]
2018-12-12 13:10 ` Claudiu Manoil
2018-12-12 13:30 ` Joakim Tjernlund
2018-12-12 14:25 ` Joakim Tjernlund
2018-12-12 14:51 ` Andrew Lunn
2018-12-12 17:25 ` Joakim Tjernlund
2018-12-12 18:34 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212124232.GB1549@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=joakim.tjernlund@infinera.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).