From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eyal Birger <eyal.birger@gmail.com>
Subject: Re: [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS
Date: Wed, 12 Dec 2018 14:01:22 +0200
Message-ID: <20181212140122.32bf401c@jimi>
References: <20181212113508.5089-1-wong.syrone@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Syrone Wong <wong.syrone@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f46.google.com ([209.85.221.46]:35782 "EHLO
        mail-wr1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726970AbeLLMB3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 12 Dec 2018 07:01:29 -0500
Received: by mail-wr1-f46.google.com with SMTP id 96so17443266wrb.2
        for <netdev@vger.kernel.org>; Wed, 12 Dec 2018 04:01:28 -0800 (PST)
In-Reply-To: <20181212113508.5089-1-wong.syrone@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 12 Dec 2018 19:35:08 +0800
Syrone Wong <wong.syrone@gmail.com> wrote:

> The incorrect setting of LDFLAGS causes error below:
> 
> > em_ipt.o: In function `em_ipt_print_epot':
> > em_ipt.c:(.text.em_ipt_print_epot+0x2e): undefined reference to
> > `xtables_init_all'  
> 
> em_ipt.c gets involved when TC_CONFIG_XT=y, which requires xtables,
> while tc/Makefile doesn't pass flags correctly. It adds '-lxtables'
> to LDFLAGS instead of LDLIBS.
> 
> Fixes: dd296215 ("tc: add em_ipt ematch for calling xtables matches
> from tc matching context")
> 
> Signed-off-by: Syrone Wong <wong.syrone@gmail.com>

Thanks!

So iiuc there's some other LDFLAG coming after -lxtables on some
platform? sorry about that..

You can add my:

Acked-by: Eyal Birger <eyal.birger@gmail.com>

Eyal.