From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH 6/7] selftest/bpf: remove redundant parenthesis
Date: Wed, 12 Dec 2018 16:25:03 -0800
Message-ID: <20181212162503.6fe270f6@cakuba.netronome.com>
References: <20181211115607.13774-1-alice.ferrazzi@gmail.com>
        <20181211115607.13774-7-alice.ferrazzi@gmail.com>
        <20181212110404.2e211ef1@cakuba.netronome.com>
        <31fc0e28-8f34-1b44-c6b1-9441c6e26c9e@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: Alice Ferrazzi <alice.ferrazzi@gmail.com>, <ast@kernel.org>,
        <daniel@iogearbox.net>, <shuah@kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
To: Edward Cree <ecree@solarflare.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <31fc0e28-8f34-1b44-c6b1-9441c6e26c9e@solarflare.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Wed, 12 Dec 2018 21:15:52 +0000, Edward Cree wrote:
> On 12/12/18 19:04, Jakub Kicinski wrote:
> > On Tue, 11 Dec 2018 20:56:06 +0900, Alice Ferrazzi wrote: =20
> >> Signed-off-by: Alice Ferrazzi <alice.ferrazzi@gmail.com>
> >> ---
> >>  tools/testing/selftests/bpf/test_offload.py | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testi=
ng/selftests/bpf/test_offload.py
> >> index 0f9130ebfd2c..b06cc0eea0eb 100755
> >> --- a/tools/testing/selftests/bpf/test_offload.py
> >> +++ b/tools/testing/selftests/bpf/test_offload.py
> >> @@ -140,7 +140,7 @@ def cmd_result(proc, include_stderr=3DFalse, fail=
=3DFalse):
> >> =20
> >> =20
> >>  def rm(f):
> >> -    cmd("rm -f %s" % (f))
> >> +    cmd("rm -f %s" % f)
> >>      if f in files:
> >>          files.remove(f)
> >>   =20
> > Is this in PEP8, too? =20
> I don't know, but it shouldn't be.
> If f is a sequence type, both the old and new code can break here,
> =C2=A0throwing a TypeError.=C2=A0 It should be cmd("rm -f %s" % (f,)).=C2=
=A0 The
> =C2=A0presence of the brackets suggests to me that that's what the
> =C2=A0original author intended.

Agreed, that was my intention, I didn't know about the comma option.

> Now, it's unlikely that we'd ever want to pass a list or tuple
> =C2=A0here, since 'rm' wouldn't understand the result, but the proper
> =C2=A0way to deal with that is an assertion with a meaningful message,
> =C2=A0since the TypeError here will have the non-obvious message "not
> =C2=A0all arguments converted during string formatting".

Interesting, thanks for the analysis!