From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Subject: Re: [PATCH net 0/2] aqc111: Thermal throttling feature
Date: Wed, 12 Dec 2018 21:38:46 +0100 [thread overview]
Message-ID: <20181212203846.GD14328@lunn.ch> (raw)
In-Reply-To: <ce7d3cb2-9cd4-5901-b1bd-9401f6895100@aquantia.com>
> A whole separate concern is how much userspace should be involved here.
> It could be a very device specific (and therefore driver specific) logic
> on how to do device's thermal control.
Hi Igor
Well, if you fully expose the PHY to Linux using a PHY driver, it
would not be device specific at all. The PHY layer knows how to ask
the PHY to drop to lower speeds. The Marvell PHYs with their
temperature sensors could also use this core code.
You are running into trouble because you want to both to hide the PHY
from Linux, but also have Linux control the PHY to avoid it melting.
This is why i actually think you should be doing this in firmware.
Andrew
next prev parent reply other threads:[~2018-12-12 20:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 13:50 [PATCH net 0/2] aqc111: Thermal throttling feature Igor Russkikh
2018-12-12 13:50 ` [PATCH net 1/2] net: usb: aqc111: Add read_mdio operation Igor Russkikh
2018-12-12 16:11 ` Andrew Lunn
2018-12-12 19:38 ` Igor Russkikh
2018-12-12 13:50 ` [PATCH net 2/2] net: usb: aqc111: Support for thermal throttling feature Igor Russkikh
2018-12-12 16:08 ` Andrew Lunn
2018-12-12 19:34 ` Igor Russkikh
2018-12-12 20:28 ` Andrew Lunn
2018-12-12 13:54 ` [PATCH net 0/2] aqc111: Thermal " Igor Russkikh
2018-12-12 18:15 ` Florian Fainelli
2018-12-12 20:08 ` Igor Russkikh
2018-12-12 20:28 ` Florian Fainelli
2018-12-12 20:38 ` Andrew Lunn [this message]
2018-12-13 0:43 ` David Miller
2018-12-14 11:43 ` Igor Russkikh
2018-12-13 0:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212203846.GD14328@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).