netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: wangyan <wangyan122@huawei.com>
Cc: jasowang@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, piaojun <piaojun@huawei.com>,
	hch@lst.de, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] vhost: correct the related warning message
Date: Wed, 12 Dec 2018 21:03:01 -0500	[thread overview]
Message-ID: <20181212210254-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5C11B176.4040704@huawei.com>

On Thu, Dec 13, 2018 at 09:10:14AM +0800, wangyan wrote:
> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
>        'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
> 
> Signed-off-by: Yan Wang <wangyan122@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>

Applied, thanks!

> ---
>  drivers/vhost/scsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 50dffe8..b459b69 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
>  
>  	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
>  					  &vc->out_iter))) {
> -		vq_err(vq, "Faulted on copy_from_iter\n");
> +		vq_err(vq, "Faulted on copy_from_iter_full\n");
>  	} else if (unlikely(*vc->lunp != 1)) {
>  		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
>  		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
> @@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
>  			se_tpg = &tpg->se_tpg;
>  			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
>  			if (ret) {
> -				pr_warn("configfs_depend_item() failed: %d\n", ret);
> +				pr_warn("target_depend_item() failed: %d\n", ret);
>  				kfree(vs_tpg);
>  				mutex_unlock(&tpg->tv_tpg_mutex);
>  				goto out;
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2018-12-13  2:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  1:10 [PATCH] vhost: correct the related warning message wangyan
2018-12-13  2:03 ` Michael S. Tsirkin [this message]
2018-12-13  9:05 ` Sergei Shtylyov
2018-12-13 15:21   ` Michael S. Tsirkin
2018-12-13 20:06     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212210254-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=hch@lst.de \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=piaojun@huawei.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wangyan122@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).