From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Thu, 13 Dec 2018 09:38:12 +0100
Message-ID: <20181213083812.GA1605@lunn.ch>
References: <20181213020150.17099-1-marex@denx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com
To: Marek Vasut <marex@denx.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:45837 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726578AbeLMIiQ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 13 Dec 2018 03:38:16 -0500
Content-Disposition: inline
In-Reply-To: <20181213020150.17099-1-marex@denx.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> +static int tja11xx_config_aneg(struct phy_device *phydev)
> +{
> +	phydev->autoneg = 0;
> +	phydev->speed = SPEED_100;
> +	phydev->duplex = DUPLEX_FULL;
> +	phydev->pause = 0;
> +	phydev->asym_pause = 0;
> +
> +	return 0;
> +}

Hi Marek

That is, err, interesting. Are you saying the PHY cannot do auto-neg?

Does it happen to be a 100T1 device for automotive?

> +
> +static int tja11xx_config_init(struct phy_device *phydev)
> +{
> +	u32 features = SUPPORTED_TP | SUPPORTED_MII | SUPPORTED_100baseT_Full;
> +	int ret;
> +
> +	ret = tja11xx_enable_reg_write(phydev);
> +	if (ret)
> +		return ret;
> +
> +	phydev->supported &= features;
> +	phydev->advertising &= features;

What tree is this code based on? I doubt it is net-next. Please rebase
and fix up all the things that then break.

    Thanks
	Andrew