netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "saeedm@dev.mellanox.co.il" <saeedm@dev.mellanox.co.il>,
	"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding
Date: Thu, 13 Dec 2018 09:40:10 +0100	[thread overview]
Message-ID: <20181213084010.GB6169@pcnci.linuxbox.cz> (raw)
In-Reply-To: <f3023c906bc9964eabd3aa8c58258c8b670a7fe3.camel@mellanox.com>

Hi Saeed,

> for now i feel that you don't want csum complete in your servers and we
> already have the tool for that, just do:
> 
> ethtool --set-priv-flags <ifname> rx_no_csum_complete on
> ethtool --show-priv-flags <ifname>
> Private flags for p5p1:
> rx_cqe_moder       : on
> tx_cqe_moder       : off
> rx_cqe_compress    : off
> rx_striding_rq     : off
> rx_no_csum_complete: on
> 
> this will disable csum complete and avoid the csum error for padded
> short packets.

we're experiencing the same issue with 4.19 and I'd like to hotfix
it now before the issue is fixed in the kernel.. however I don't see
the flags in ethtool (even with latest 4.19 version..)

I'm using following cards:

d8:00.0 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx]

Am i doing something wrong, or is this different issue?

thanks a lot in advance

BR

nik







> 
> 
> Thanks,
> Saeed.
> 

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28.rijna 168, 709 00 Ostrava

tel.:   +420 591 166 214
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

  parent reply	other threads:[~2018-12-13  8:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  6:10 [Patch net v2] mlx5: fixup checksum for short ethernet frame padding Cong Wang
2018-11-28 15:00 ` Eric Dumazet
2018-11-28 22:16   ` Cong Wang
2018-11-28 23:50     ` Eric Dumazet
2018-11-28 23:57       ` Cong Wang
2018-11-29  0:05         ` Cong Wang
2018-11-29  0:14           ` Eric Dumazet
2018-11-30  0:03           ` Saeed Mahameed
2018-11-29  0:07         ` Eric Dumazet
2018-11-29  3:40           ` Cong Wang
2018-11-29  3:49             ` Eric Dumazet
2018-11-29  3:53               ` Cong Wang
2018-11-29  4:09                 ` Eric Dumazet
2018-11-30  0:30                   ` Saeed Mahameed
2018-12-03 23:17 ` David Miller
2018-12-03 23:45   ` Cong Wang
2018-12-04 19:21   ` Saeed Mahameed
2018-12-04 20:50     ` Cong Wang
2018-12-05  1:06       ` Saeed Mahameed
2018-12-05  2:15         ` Cong Wang
2018-12-13  8:40         ` Nikola Ciprich [this message]
2018-12-13 17:08           ` Saeed Mahameed
2018-12-14  9:33             ` Nikola Ciprich
2019-01-05 18:35             ` Nikola Ciprich
2019-01-06 11:10               ` Saeed Mahameed
2019-01-18  1:19                 ` Christoph Paasch
2019-01-19  0:45                   ` Saeed Mahameed
2019-01-22 11:35                     ` David Laight
2018-12-05  2:52 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213084010.GB6169@pcnci.linuxbox.cz \
    --to=nikola.ciprich@linuxbox.cz \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@dev.mellanox.co.il \
    --cc=saeedm@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).