From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikola Ciprich Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding Date: Thu, 13 Dec 2018 09:40:10 +0100 Message-ID: <20181213084010.GB6169@pcnci.linuxbox.cz> References: <20181128061013.3885-1-xiyou.wangcong@gmail.com> <20181203.151724.648093455366632499.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "saeedm@dev.mellanox.co.il" , "xiyou.wangcong@gmail.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "edumazet@google.com" , Nikola Ciprich To: Saeed Mahameed Return-path: Received: from gwu.lbox.cz ([62.245.111.132]:60416 "EHLO gwu.lbox.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726416AbeLMItS (ORCPT ); Thu, 13 Dec 2018 03:49:18 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi Saeed, > for now i feel that you don't want csum complete in your servers and we > already have the tool for that, just do: > > ethtool --set-priv-flags rx_no_csum_complete on > ethtool --show-priv-flags > Private flags for p5p1: > rx_cqe_moder : on > tx_cqe_moder : off > rx_cqe_compress : off > rx_striding_rq : off > rx_no_csum_complete: on > > this will disable csum complete and avoid the csum error for padded > short packets. we're experiencing the same issue with 4.19 and I'd like to hotfix it now before the issue is fixed in the kernel.. however I don't see the flags in ethtool (even with latest 4.19 version..) I'm using following cards: d8:00.0 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] Am i doing something wrong, or is this different issue? thanks a lot in advance BR nik > > > Thanks, > Saeed. > -- ------------------------------------- Ing. Nikola CIPRICH LinuxBox.cz, s.r.o. 28.rijna 168, 709 00 Ostrava tel.: +420 591 166 214 fax: +420 596 621 273 mobil: +420 777 093 799 www.linuxbox.cz mobil servis: +420 737 238 656 email servis: servis@linuxbox.cz -------------------------------------