From: Andrew Lunn <andrew@lunn.ch>
To: Biao Huang <biao.huang@mediatek.com>
Cc: davem@davemloft.net, robh+dt@kernel.org,
honghui.zhang@mediatek.com, yt.shen@mediatek.com,
liguo.zhang@mediatek.com, mark.rutland@arm.com,
nelson.chang@mediatek.com, matthias.bgg@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, joabreu@synopsys.com
Subject: Re: [v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC
Date: Thu, 13 Dec 2018 13:36:58 +0100 [thread overview]
Message-ID: <20181213123658.GG1605@lunn.ch> (raw)
In-Reply-To: <1544666173-5121-3-git-send-email-biao.huang@mediatek.com>
> +- mediatek,rx-delay-ps: RX clock delay macro value. Default is 0.
> + It should be defined for rgmii/rgmii-txid/mii/rmii interface.
> +Both delay properties need to be a multiple of 170 for fine-tune rgmii,
> +range 0~31*170.
> +Both delay properties need to be a multiple of 550 for coarse-tune rgmii,
> +range 0~31*550.
> +Both delay properties need to be a multiple of 550 for mii/rmii,
> +range 0~31*550.
You see "need to be" here, but the driver does not care. It will round
down. Please either make the driver check, or change the text to
rather say it will round down.
Andrew
next prev parent reply other threads:[~2018-12-13 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 1:56 [v7, PATCH 0/2] add Ethernet driver support for mt2712 Biao Huang
2018-12-13 1:56 ` [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add " Biao Huang
2018-12-13 12:33 ` Andrew Lunn
2018-12-14 3:01 ` biao huang
2018-12-14 5:11 ` Florian Fainelli
2018-12-14 6:32 ` biao huang
2018-12-13 1:56 ` [v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC Biao Huang
2018-12-13 12:36 ` Andrew Lunn [this message]
2018-12-14 2:24 ` biao huang
2018-12-13 2:48 ` [v7, PATCH 0/2] add Ethernet driver support for mt2712 biao huang
2018-12-13 5:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213123658.GG1605@lunn.ch \
--to=andrew@lunn.ch \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=honghui.zhang@mediatek.com \
--cc=joabreu@synopsys.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nelson.chang@mediatek.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).