[iproute2-next] tc: fix xtables incorrect usage of LDFLAGS

[iproute2-next] tc: fix xtables incorrect usage of LDFLAGS

[Syrone Wong]

The incorrect setting of LDFLAGS causes error below:

> em_ipt.o: In function `em_ipt_print_epot':
> em_ipt.c:(.text.em_ipt_print_epot+0x2e): undefined reference to
> `xtables_init_all'

em_ipt.c gets involved when TC_CONFIG_XT=y, which requires xtables,
while tc/Makefile doesn't pass flags correctly. It adds '-lxtables'
to LDFLAGS instead of LDLIBS.

Fixes: dd296215 ("tc: add em_ipt ematch for calling xtables matches from tc matching context")

Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
---
 tc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/Makefile b/tc/Makefile
index f8010d3c..2edaf2c8 100644
--- a/tc/Makefile
+++ b/tc/Makefile
@@ -171,7 +171,7 @@ em_ipset.o: CFLAGS += $$($(PKG_CONFIG) xtables --cflags)
 em_ipt.o: CFLAGS += $$($(PKG_CONFIG) xtables --cflags)
 
 ifeq ($(TC_CONFIG_XT),y)
-  LDFLAGS += $$($(PKG_CONFIG) xtables --libs)
+  LDLIBS += $$($(PKG_CONFIG) xtables --libs)
 endif
 
 %.yacc.c: %.y
-- 
2.20.0

Re: [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS

[Eyal Birger]

On Wed, 12 Dec 2018 19:35:08 +0800
Syrone Wong <wong.syrone@gmail.com> wrote:

> The incorrect setting of LDFLAGS causes error below:
> 
> > em_ipt.o: In function `em_ipt_print_epot':
> > em_ipt.c:(.text.em_ipt_print_epot+0x2e): undefined reference to
> > `xtables_init_all'  
> 
> em_ipt.c gets involved when TC_CONFIG_XT=y, which requires xtables,
> while tc/Makefile doesn't pass flags correctly. It adds '-lxtables'
> to LDFLAGS instead of LDLIBS.
> 
> Fixes: dd296215 ("tc: add em_ipt ematch for calling xtables matches
> from tc matching context")
> 
> Signed-off-by: Syrone Wong <wong.syrone@gmail.com>

Thanks!

So iiuc there's some other LDFLAG coming after -lxtables on some
platform? sorry about that..

You can add my:

Acked-by: Eyal Birger <eyal.birger@gmail.com>

Eyal.

Re: [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS

[Syrone Wong]

> So iiuc there's some other LDFLAG coming after -lxtables on some
> platform? sorry about that..

Issue found when compiling iproute2 4.17 for OpenWrt

https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg42783.html

Syrone Wong

Re: [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS

[Stephen Hemminger]

On Wed, 12 Dec 2018 20:04:07 +0800
Syrone Wong <wong.syrone@gmail.com> wrote:

> > So iiuc there's some other LDFLAG coming after -lxtables on some
> > platform? sorry about that..  
> 
> Issue found when compiling iproute2 4.17 for OpenWrt
> 
> https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg42783.html
> 
> Syrone Wong

Applied, thanks.