From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2' Date: Thu, 13 Dec 2018 15:02:39 +0000 (UTC) Message-ID: <20181213150239.762F8601EA@smtp.codeaurora.org> References: <1543994766-7057-1-git-send-email-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Priit Laes , Kees Cook , YueHaibing , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jia-Ju Bai , b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Larry Finger To: YueHaibing Return-path: In-Reply-To: <1543994766-7057-1-git-send-email-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "b43-dev" Errors-To: b43-dev-bounces+gldbd-bcm43xx-dev=gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower': > drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning: > variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable] > > drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning: > variable 'tmp2' set but not used [-Wunused-but-set-variable] > > 'tx_pwr_state' never used since introduction in commit > 8615eb2870f1 ("b43: N-PHY: support setting custom TX power") > > 'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper > for checking IPA") > > Signed-off-by: YueHaibing Patch applied to wireless-drivers-next.git, thanks. 662a7b078cff b43: remove set but not used variables 'tx_pwr_state,tmp2' -- https://patchwork.kernel.org/patch/10713095/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches