From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH V2 2/3] net: dsa: ksz: Factor out common tag code
Date: Fri, 14 Dec 2018 10:05:25 +0100
Message-ID: <20181214090525.GA5513@lunn.ch>
References: <20181213160159.18956-1-marex@denx.de>
 <20181213160159.18956-3-marex@denx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
        Tristram Ha <Tristram.Ha@microchip.com>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        "David S . Miller" <davem@davemloft.net>
To: Marek Vasut <marex@denx.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:47456 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726298AbeLNJF2 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 14 Dec 2018 04:05:28 -0500
Content-Disposition: inline
In-Reply-To: <20181213160159.18956-3-marex@denx.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> +static struct sk_buff *ksz_common_xmit(struct sk_buff *skb,
> +				       struct net_device *dev, int len)
>  {
> -	struct dsa_port *dp = dsa_slave_to_port(dev);
>  	struct sk_buff *nskb;
>  	int padlen;
> -	u8 *tag;
>  
>  	padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len;
>  
> -	if (skb_tailroom(skb) >= padlen + KSZ_INGRESS_TAG_LEN) {
> +	if (skb_tailroom(skb) >= padlen + len) {
>  		/* Let dsa_slave_xmit() free skb */
>  		if (__skb_put_padto(skb, skb->len + padlen, false))
>  			return NULL;

Hi Marek

This can return NULL.

> +static struct sk_buff *ksz9477_xmit(struct sk_buff *skb,
> +				    struct net_device *dev)
> +{
> +	struct dsa_port *dp = dsa_slave_to_port(dev);
> +	struct sk_buff *nskb;
> +	u16 *tag;
> +	u8 *addr;
> +
> +	nskb = ksz_common_xmit(skb, dev, KSZ9477_INGRESS_TAG_LEN);

So here you need to check for NULL

Otherwise, i like it. Thanks for removing the function pointer.

	   Andrew