netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"saeedm@dev.mellanox.co.il" <saeedm@dev.mellanox.co.il>,
	"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
	"edumazet@google.com" <edumazet@google.com>,
	Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding
Date: Fri, 14 Dec 2018 10:33:51 +0100	[thread overview]
Message-ID: <20181214093351.GJ18804@pcnci.linuxbox.cz> (raw)
In-Reply-To: <dd3d10e5b14a1ccceed52e19e83179993efc1f8e.camel@mellanox.com>

> Hi Nikola
> 
> 4.19 is missing this priv flag, it was only submitted to 4.20
> 
> commit b856df28f9230a47669efbdd57896084caadb2b3
> Author: Or Gerlitz <ogerlitz@mellanox.com>
> Date:   Sun Jul 1 08:58:38 2018 +0000
> 
>     net/mlx5e: Allow reporting of checksum unnecessary
> 
> 
> > I'm using following cards:
> > 
> > d8:00.0 Ethernet controller: Mellanox Technologies MT27710 Family
> > [ConnectX-4 Lx]
> > 
> > Am i doing something wrong, or is this different issue?
> > 
> 
> Most likely the same issue, we are finalizing the patch initially
> proposed by Cong, you can find it here, I plan to submit it next week,
> after all the regression tests.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=topic/csum-fix
> 
> It would be nice if you verify this fixes your issue.
> 
> Thanks,
> Saeed.
Hi Saeed,

thanks! both patches seem to depend on lots of previous changes, so it'll
take me some time to cherrypick all needed fixes and test it with 4.19

once I'm done, I'll report!

BR

nik



-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28.rijna 168, 709 00 Ostrava

tel.:   +420 591 166 214
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

  reply	other threads:[~2018-12-14  9:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  6:10 [Patch net v2] mlx5: fixup checksum for short ethernet frame padding Cong Wang
2018-11-28 15:00 ` Eric Dumazet
2018-11-28 22:16   ` Cong Wang
2018-11-28 23:50     ` Eric Dumazet
2018-11-28 23:57       ` Cong Wang
2018-11-29  0:05         ` Cong Wang
2018-11-29  0:14           ` Eric Dumazet
2018-11-30  0:03           ` Saeed Mahameed
2018-11-29  0:07         ` Eric Dumazet
2018-11-29  3:40           ` Cong Wang
2018-11-29  3:49             ` Eric Dumazet
2018-11-29  3:53               ` Cong Wang
2018-11-29  4:09                 ` Eric Dumazet
2018-11-30  0:30                   ` Saeed Mahameed
2018-12-03 23:17 ` David Miller
2018-12-03 23:45   ` Cong Wang
2018-12-04 19:21   ` Saeed Mahameed
2018-12-04 20:50     ` Cong Wang
2018-12-05  1:06       ` Saeed Mahameed
2018-12-05  2:15         ` Cong Wang
2018-12-13  8:40         ` Nikola Ciprich
2018-12-13 17:08           ` Saeed Mahameed
2018-12-14  9:33             ` Nikola Ciprich [this message]
2019-01-05 18:35             ` Nikola Ciprich
2019-01-06 11:10               ` Saeed Mahameed
2019-01-18  1:19                 ` Christoph Paasch
2019-01-19  0:45                   ` Saeed Mahameed
2019-01-22 11:35                     ` David Laight
2018-12-05  2:52 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214093351.GJ18804@pcnci.linuxbox.cz \
    --to=nikola.ciprich@linuxbox.cz \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@dev.mellanox.co.il \
    --cc=saeedm@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).