From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [net-next, PATCH 2/2] net: socionext: remove mmio reads on Tx
Date: Fri, 14 Dec 2018 16:32:59 +0200
Message-ID: <20181214143259.GA12115@apalos>
References: <1544777941-24083-1-git-send-email-ilias.apalodimas@linaro.org>
 <1544777941-24083-2-git-send-email-ilias.apalodimas@linaro.org>
 <CAKv+Gu-AWV94vVThi-YPLWganMgNc=+OUZOG6jeqeLzUOMb+Nw@mail.gmail.com>
 <20181214111805.GA2434@apalos>
 <CAKv+Gu-bOESCGxS6EdOGArzA8VueA+WCruDugMrc6Fj_ve7hCg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
        Jaswinder Singh <jaswinder.singh@linaro.org>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        Masahisa Kojima <masahisa.kojima@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f66.google.com ([209.85.128.66]:51411 "EHLO
        mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729766AbeLNOdE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 14 Dec 2018 09:33:04 -0500
Received: by mail-wm1-f66.google.com with SMTP id s14so5898111wmh.1
        for <netdev@vger.kernel.org>; Fri, 14 Dec 2018 06:33:03 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CAKv+Gu-bOESCGxS6EdOGArzA8VueA+WCruDugMrc6Fj_ve7hCg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Ard,
> > >
> > > So shouldn't we do this *after* processing Rx, and only if there is budget left?
> >
> > I am not really sure, this would drown Tx processing if you had a bunch of
> > received packets that exhausted the budget.
> > Intel 1gbit drivers are doing something similar. They reclaim Tx prior to
> > processing Rx. The only thing that could be checked here i guess is keep the
> > napi poll running if *all* Tx descriptors were processed at some point instead
> > of re-enabling irqs.
> >
> 
> The reason I suggest it is because you quoted it from the documentation :-)

Yes i understand. I had my doubts as well.
That's hy i tried following the example of another driver.

> 
> But if reality deviates from that, then sure, let's follow the
> examples of others.

Agree. Unless someone has any objections i am fine with the current patches.


Thanks!
/Ilias