Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports

[Antoine Tenart <antoine.tenart@bootlin.com>]

Hi Russell,

On Fri, Dec 14, 2018 at 04:02:50PM +0000, Russell King - ARM Linux wrote:
> On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote:
> > The mvpp2_phylink_validate() function sets all modes that are
> > supported by a given PPv2 port. A recent change made all ports to
> > advertise they support 10G modes in certain cases. This is not true,
> > as only the port #0 can do so. This patch fixes it.
> > 
> > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules")
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> 
> Looking at net-next, I think there's more to be fixed here:
> 
>         case PHY_INTERFACE_MODE_RGMII:
>         case PHY_INTERFACE_MODE_RGMII_ID:
>         case PHY_INTERFACE_MODE_RGMII_RXID:
>         case PHY_INTERFACE_MODE_RGMII_TXID:
>         case PHY_INTERFACE_MODE_SGMII:
> ...
> 		phylink_set(mask, 10000baseT_Full);
> 
> Is that really true?

Good catch. Will you send a fix or do you want me to do it?

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com