From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Subject: Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports Date: Fri, 14 Dec 2018 17:09:44 +0100 Message-ID: <20181214160944.GE20364@kwain> References: <20181214093451.26314-1-antoine.tenart@bootlin.com> <20181214160249.GD26090@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Antoine Tenart , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com, Baruch Siach To: Russell King - ARM Linux Return-path: Content-Disposition: inline In-Reply-To: <20181214160249.GD26090@n2100.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Russell, On Fri, Dec 14, 2018 at 04:02:50PM +0000, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote: > > The mvpp2_phylink_validate() function sets all modes that are > > supported by a given PPv2 port. A recent change made all ports to > > advertise they support 10G modes in certain cases. This is not true, > > as only the port #0 can do so. This patch fixes it. > > > > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") > > Cc: Baruch Siach > > Signed-off-by: Antoine Tenart > > Looking at net-next, I think there's more to be fixed here: > > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > case PHY_INTERFACE_MODE_SGMII: > ... > phylink_set(mask, 10000baseT_Full); > > Is that really true? Good catch. Will you send a fix or do you want me to do it? Thanks, Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com