From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Subject: [PATCH 1/7] ethtool: dsa: add pretty dump Date: Fri, 14 Dec 2018 21:50:29 -0500 Message-ID: <20181215025035.26977-2-vivien.didelot@gmail.com> References: <20181215025035.26977-1-vivien.didelot@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Chris Healy , Vivien Didelot , "John W . Linville" , f.fainelli@gmail.com, andrew@lunn.ch To: netdev@vger.kernel.org Return-path: Received: from mail-qt1-f194.google.com ([209.85.160.194]:33032 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727668AbeLOCvN (ORCPT ); Fri, 14 Dec 2018 21:51:13 -0500 Received: by mail-qt1-f194.google.com with SMTP id l11so8484135qtp.0 for ; Fri, 14 Dec 2018 18:51:12 -0800 (PST) In-Reply-To: <20181215025035.26977-1-vivien.didelot@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: This patch adds the preliminary bits for pretty dumping the registers of the "dsa" kernel drivers. Following patches will add support for the "mv88e6xxx" DSA driver. Signed-off-by: Vivien Didelot --- Makefile.am | 2 +- dsa.c | 12 ++++++++++++ ethtool.c | 1 + internal.h | 3 +++ 4 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 dsa.c diff --git a/Makefile.am b/Makefile.am index 14f79b6..468eed1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,7 +9,7 @@ ethtool_SOURCES = ethtool.c ethtool-copy.h internal.h net_tstamp-copy.h \ rxclass.c if ETHTOOL_ENABLE_PRETTY_DUMP ethtool_SOURCES += \ - amd8111e.c de2104x.c e100.c e1000.c et131x.c igb.c \ + amd8111e.c de2104x.c dsa.c e100.c e1000.c et131x.c igb.c \ fec_8xx.c ibm_emac.c ixgb.c ixgbe.c natsemi.c \ pcnet32.c realtek.c tg3.c marvell.c vioc.c \ smsc911x.c at76c50x-usb.c sfc.c stmmac.c \ diff --git a/dsa.c b/dsa.c new file mode 100644 index 0000000..83396b5 --- /dev/null +++ b/dsa.c @@ -0,0 +1,12 @@ +#include +#include + +#include "internal.h" + +int dsa_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs) +{ + /* DSA per-driver register dump */ + + /* Fallback to hexdump */ + return 1; +} diff --git a/ethtool.c b/ethtool.c index 2f7e96b..f1f1ec2 100644 --- a/ethtool.c +++ b/ethtool.c @@ -1166,6 +1166,7 @@ static const struct { { "vmxnet3", vmxnet3_dump_regs }, { "fjes", fjes_dump_regs }, { "lan78xx", lan78xx_dump_regs }, + { "dsa", dsa_dump_regs }, #endif }; diff --git a/internal.h b/internal.h index b239dc7..84b0f9c 100644 --- a/internal.h +++ b/internal.h @@ -354,4 +354,7 @@ int fjes_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs); /* MICROCHIP LAN78XX USB ETHERNET Controller */ int lan78xx_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs); +/* Distributed Switch Architecture */ +int dsa_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs); + #endif /* ETHTOOL_INTERNAL_H__ */ -- 2.19.2