From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yangtao Li Subject: [PATCH] ipconfig: convert to DEFINE_SHOW_ATTRIBUTE Date: Sat, 15 Dec 2018 02:19:53 -0500 Message-ID: <20181215071953.25930-1-tiny.windzz@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yangtao Li To: davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:41585 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728675AbeLOHT5 (ORCPT ); Sat, 15 Dec 2018 02:19:57 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- net/ipv4/ipconfig.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 88212615bf4c..fcb817d0eb24 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4/ipconfig.c @@ -1361,18 +1361,7 @@ static int ntp_servers_seq_show(struct seq_file *seq, void *v) } return 0; } - -static int ntp_servers_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, ntp_servers_seq_show, NULL); -} - -static const struct file_operations ntp_servers_seq_fops = { - .open = ntp_servers_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(ntp_servers_seq); #endif /* CONFIG_PROC_FS */ /* -- 2.17.0