From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Vorel <petr.vorel@gmail.com>
Subject: Re: [PATCH iproute2 1/4] Makefile: have check target depend on all
Date: Sat, 15 Dec 2018 17:13:04 +0100
Message-ID: <20181215161302.GA1718@x230>
References: <20181215153051.13166-1-bluca@debian.org>
Reply-To: Petr Vorel <petr.vorel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
        Petr Vorel <pvorel@suse.cz>
To: Luca Boccassi <bluca@debian.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f67.google.com ([209.85.221.67]:34210 "EHLO
        mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730119AbeLOQNJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 15 Dec 2018 11:13:09 -0500
Received: by mail-wr1-f67.google.com with SMTP id j2so8250261wrw.1
        for <netdev@vger.kernel.org>; Sat, 15 Dec 2018 08:13:07 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20181215153051.13166-1-bluca@debian.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Luca,

> Otherwise it will simply fail immediately from a just-cleaned
> workspace:

> $ make check -j1
> cd testsuite && make && make alltests
> echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
> Entering iproute2
> make -C tools
> Makefile:3: ../../config.mk: No such file or directory
> make[2]: *** No rule to make target '../../config.mk'.  Stop.

> Fixes: 8804a8c0d387 ("Makefile: Add check target")
> Cc: petr.vorel@gmail.com

> Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

Thanks for a fix. I added 92885e19 ("testsuite: Fix make check when need build
generate_nlmsg"), but that wasn't enough.


Kind regards,
Petr