From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Vorel <petr.vorel@gmail.com>
Subject: Re: [PATCH iproute2 2/4] testsuite: declare dependency between
 $(TESTS) and generate_nlmsg
Date: Sat, 15 Dec 2018 17:22:13 +0100
Message-ID: <20181215162212.GA683@x230>
References: <20181215153051.13166-1-bluca@debian.org>
 <20181215153051.13166-2-bluca@debian.org>
Reply-To: Petr Vorel <petr.vorel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
        Petr Vorel <pvorel@suse.cz>
To: Luca Boccassi <bluca@debian.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ed1-f66.google.com ([209.85.208.66]:37005 "EHLO
        mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730119AbeLOQWR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 15 Dec 2018 11:22:17 -0500
Received: by mail-ed1-f66.google.com with SMTP id h15so7390223edb.4
        for <netdev@vger.kernel.org>; Sat, 15 Dec 2018 08:22:16 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20181215153051.13166-2-bluca@debian.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Luca,

> Parallel make from the top level directory fails since tests are at the
> same time as generate_nlmsg:

> $ make check -j4

> ...

> cd testsuite && make && make alltests
> echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
> Entering iproute2
> make -C tools
> Removing results dir ...
> make[1]: ./tools/generate_nlmsg: Command not found
> make[1]: ./tools/generate_nlmsg: Command not found
> Makefile:64: recipe for target 'ip/netns/set_nsid_batch.t' failed
> make[1]: *** [ip/netns/set_nsid_batch.t] Error 127
> make[1]: ./tools/generate_nlmsg: Command not found
> make[1]: *** Waiting for unfinished jobs....
> Makefile:64: recipe for target 'ip/netns/set_nsid.t' failed
> make[1]: *** [ip/netns/set_nsid.t] Error 127
> Makefile:64: recipe for target 'ip/link/show_dev_wo_vf_rate.t' failed
> make[1]: *** [ip/link/show_dev_wo_vf_rate.t] Error 127
>     CC       generate_nlmsg
> Makefile:123: recipe for target 'check' failed
> make: *** [check] Error 2

> Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
> that the tool correctly gets compiled before any test runs.

> Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed")
> Cc: petr.vorel@gmail.com

> Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

Again, thanks for fix.


Kind regards,
Petr