From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Subject: Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test Date: Sat, 15 Dec 2018 17:32:50 +0100 Message-ID: <20181215163250.GA29950@x230> References: <20181215153051.13166-1-bluca@debian.org> <20181215153051.13166-3-bluca@debian.org> Reply-To: Petr Vorel Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, stephen@networkplumber.org To: Luca Boccassi Return-path: Received: from mx2.suse.de ([195.135.220.15]:58416 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730127AbeLOQcz (ORCPT ); Sat, 15 Dec 2018 11:32:55 -0500 Content-Disposition: inline In-Reply-To: <20181215153051.13166-3-bluca@debian.org> Sender: netdev-owner@vger.kernel.org List-ID: Hi Luca, > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel > --- > testsuite/tests/ip/route/add_default_route.t | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t > index 569ba1f8..c536e35f 100755 > --- a/testsuite/tests/ip/route/add_default_route.t > +++ b/testsuite/tests/ip/route/add_default_route.t > @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst cafe:babe::/64" -6 route add cafe:babe::/ > ts_ip "$0" "Show IPv6 default route" -6 route show default > test_on "default via dead:beef::2 dev $DEV" > test_lines_count 1 > + > +ts_ip "$0" "Del $NEW_DEV dummy interface" link del dev $DEV Shouldn't this be using $DEV instead of $NEW_DEV? ts_ip "$0" "Delete $DEV interface" link del dev $DEV Copy paste from new_link.t? Kind regards, Petr