From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE Date: Sun, 16 Dec 2018 12:41:20 -0800 (PST) Message-ID: <20181216.124120.731491122771817496.davem@davemloft.net> References: <1544533009-12425-1-git-send-email-mw@semihalf.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux@armlinux.org.uk, maxime.chevallier@bootlin.com, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, antoine.tenart@bootlin.com, stefanc@marvell.com, nadavh@marvell.com, jaz@semihalf.com To: mw@semihalf.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:48124 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbeLPUlW (ORCPT ); Sun, 16 Dec 2018 15:41:22 -0500 In-Reply-To: <1544533009-12425-1-git-send-email-mw@semihalf.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Marcin Wojtas Date: Tue, 11 Dec 2018 13:56:49 +0100 > Recent changes in the mvneta driver reworked allocation > and handling of the ingress buffers to use entire pages. > Apart from that in SW BM scenario the HW must be informed > via PRXDQS about the biggest possible incoming buffer > that can be propagated by RX descriptors. > > The BufferSize field was filled according to the MTU-dependent > pkt_size value. Later change to PAGE_SIZE broke RX operation > when usin 64K pages, as the field is simply too small. > > This patch conditionally limits the value passed to the BufferSize > of the PRXDQS register, depending on the PAGE_SIZE used. > On the occasion remove now unused frag_size field of the mvneta_port > structure. > > Fixes: 562e2f467e71 ("net: mvneta: Improve the buffer allocation method for SWBM") > Signed-off-by: Marcin Wojtas The discussion died on this, but the bug should be fixed. So in the short term I am applying this and queueing it up for v4.19 -stable. Thanks.