From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: [PATCH iproute2 v2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg Date: Sun, 16 Dec 2018 13:47:25 +0000 Message-ID: <20181216134727.8342-2-bluca@debian.org> References: <20181215153051.13166-1-bluca@debian.org> <20181216134727.8342-1-bluca@debian.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: stephen@networkplumber.org, petr.vorel@gmail.com, Luca Boccassi To: netdev@vger.kernel.org Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:40685 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729910AbeLPNrm (ORCPT ); Sun, 16 Dec 2018 08:47:42 -0500 Received: by mail-wm1-f66.google.com with SMTP id q26so9980415wmf.5 for ; Sun, 16 Dec 2018 05:47:41 -0800 (PST) In-Reply-To: <20181216134727.8342-1-bluca@debian.org> Sender: netdev-owner@vger.kernel.org List-ID: Parallel make from the top level directory fails since tests are at the same time as generate_nlmsg: $ make check -j4 ... cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Removing results dir ... make[1]: ./tools/generate_nlmsg: Command not found make[1]: ./tools/generate_nlmsg: Command not found Makefile:64: recipe for target 'ip/netns/set_nsid_batch.t' failed make[1]: *** [ip/netns/set_nsid_batch.t] Error 127 make[1]: ./tools/generate_nlmsg: Command not found make[1]: *** Waiting for unfinished jobs.... Makefile:64: recipe for target 'ip/netns/set_nsid.t' failed make[1]: *** [ip/netns/set_nsid.t] Error 127 Makefile:64: recipe for target 'ip/link/show_dev_wo_vf_rate.t' failed make[1]: *** [ip/link/show_dev_wo_vf_rate.t] Error 127 CC generate_nlmsg Makefile:123: recipe for target 'check' failed make: *** [check] Error 2 Add an explicit dependency in testuite/Makefile's $(TESTS) rule so that the tool correctly gets compiled before any test runs. Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed") Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel Tested-by: Petr Vorel --- v2: added reviewed/tested-by tags, removed Cc testsuite/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index 46b243b0..9b0f1c15 100644 --- a/testsuite/Makefile +++ b/testsuite/Makefile @@ -53,7 +53,7 @@ clean: testclean distclean: clean echo "Entering iproute2" && cd iproute2 && $(MAKE) distclean && cd ..; -$(TESTS): testclean +$(TESTS): generate_nlmsg testclean ifeq (,$(IPVERS)) $(error Please run make first) endif -- 2.19.2