From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 1/2] net: phy: don't stop state machine in case
 of MDIO error
Date: Sun, 16 Dec 2018 16:30:19 +0100
Message-ID: <20181216153019.GA25181@lunn.ch>
References: <eaa82258-9be1-0105-d871-f03a0ba68162@gmail.com>
 <6e57b405-e39e-91a1-c843-f461db9bc286@gmail.com>
 <20181216084251.GD18287@lunn.ch>
 <4dfc05d9-9f4f-101f-e026-b57b0c194e1d@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        Fugang Duan <fugang.duan@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:49458 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729822AbeLPPa0 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 16 Dec 2018 10:30:26 -0500
Content-Disposition: inline
In-Reply-To: <4dfc05d9-9f4f-101f-e026-b57b0c194e1d@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> After checking the fec history it seems that at the time this
> workaround was added as part of phylib support (8 years ago),
> the MDIO access timeout value was too low and therefore sometimes
> MDIO access failed. Later timeout was set to a higher value and
> driver switched to an event-driven mechanism to signal end of
> MDIO access. So it should be safe to remove the workaround.

Hi Heiner

Thanks for digging into the details.

> 
> One issue with phy_error() is that it silently stops the PHY.
> We should at least add a phydev_err() to let the user know.

Yes, that is a good idea.

     Andrew